From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/2] gnu: Add evilwm. Date: Tue, 20 Oct 2015 09:56:48 +0200 Message-ID: <87zizex9a7.fsf@gnu.org> References: <1444948609-29345-1-git-send-email-ericbavier@openmailbox.org> <1444948609-29345-2-git-send-email-ericbavier@openmailbox.org> <87vba7tdig.fsf@gnu.org> <20151019065541.771c7a5e@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoRn0-0003n1-NM for guix-devel@gnu.org; Tue, 20 Oct 2015 03:56:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoRmz-0002IM-Dj for guix-devel@gnu.org; Tue, 20 Oct 2015 03:56:58 -0400 In-Reply-To: <20151019065541.771c7a5e@openmailbox.org> (Eric Bavier's message of "Mon, 19 Oct 2015 06:55:41 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Bavier Cc: guix-devel@gnu.org, Eric Bavier Eric Bavier skribis: > On Fri, 16 Oct 2015 10:37:43 +0200 > ludo@gnu.org (Ludovic Court=C3=A8s) wrote: [...] >> Since =E2=80=98fsf-free=E2=80=99 is a catch-all thing, could you add a c= omment >> explaining in one line what kind of license this is? > > Upon closer reading of the README, I've updated the license field to > '(x11-style "file:///README")'. Of course, second opinions welcome, > especially since http://directory.fsf.org/wiki/Evilwm claims both > "Other" and "GPLv2orlater" licenses, and > http://directory.fsf.org/wiki/Aewm which evilwm is based on claims the > "Expat" license. On a cursory look at =E2=80=98README=E2=80=99, x11-style sounds right to me. > From 024a556bdc82a569b6c07873df221ae7e50f1fb0 Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Mon, 19 Oct 2015 06:44:23 -0500 > Subject: [PATCH 2/4] font-alias: Install dummy fonts.dir files. > > * gnu/packages/xorg.scm (font-alias)[arguments]: New 'install-fonts-dir' > phase. Good catch! LGTM. > + 'install 'install-fonts-dir > + ;; The X font server will not add directories to the = font > + ;; path unless they contain a "fonts.dir" file, so ad= d some > + ;; dummy files. > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (for-each (lambda (d) > + (call-with-output-file > + (string-append out "/share/fonts/= X11" > + "/" d "/fonts.dir") > + (lambda (p) > + (format p "0~%")))) > + '("75dpi" "100dpi" "misc" "cyrillic")) So how did you settle on "0~%"? :-) > From d5446a060f7ffe6d419d64bf5c3a0a51736a47d0 Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Mon, 19 Oct 2015 06:45:31 -0500 > Subject: [PATCH 3/4] services: xorg: Include font-alias in default FontPa= th. > > * gnu/services/xorg.scm (xorg-configuration-file): Add font-alias directo= ries > to xserver.conf FontPath. OK. > From 45c524710742550013a8513b641e8d488806f7c9 Mon Sep 17 00:00:00 2001 > From: Eric Bavier > Date: Thu, 15 Oct 2015 17:34:26 -0500 > Subject: [PATCH 4/4] gnu: Add evilwm. > > * gnu/packages/wm.scm (evilwm): New variable. [...] > + (arguments > + `(#:modules ((srfi srfi-26) > + ,@%gnu-build-system-modules) Note that %GNU-BUILD-SYSTEM-MODULES is the set of modules *imported* in the build environment (inputs of the derivation), not the set of modules visible in the build script. See =E2=80=98%default-modules=E2=80=99 vs. =E2=80=98%gnu-build-system-modules=E2=80=99 in (guix build-system gnu) = for the difference. So it should rather be: #:modules ((srfi srfi-26) (guix build utils) (guix build gnu-build-system)) In practice it probably won=E2=80=99t make any difference. Otherwise LGTM. Thanks! Ludo=E2=80=99.