unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Replace broken LADSPA URL.
@ 2015-11-16 19:33 Ricardo Wurmus
  2015-11-17  8:45 ` Alex Kost
  0 siblings, 1 reply; 15+ messages in thread
From: Ricardo Wurmus @ 2015-11-16 19:33 UTC (permalink / raw)
  To: guix-devel@gnu.org

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

The ladspa.org domain appears to be no longer under control of the
LADSPA project (does it still exist?).

The attached patch changes the source URL such that it downloads the
last copy archived by http://web.archive.org.  Is this okay or should we
look for a more permanent home for the LADSPA sources?

~~ Ricardo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-ladspa-Download-sources-from-web-archive.patch --]
[-- Type: text/x-patch, Size: 1569 bytes --]

From 0524fcfaf534543621e78145cadbc2cb8eca6da4 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Mon, 16 Nov 2015 20:25:27 +0100
Subject: [PATCH] gnu: ladspa: Download sources from web archive.

* gnu/packages/audio.scm (ladspa)[source]: Replace broken URL with web
  archive URL.
---
 gnu/packages/audio.scm | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 4a86a8d..23a5355 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -755,14 +755,15 @@ plugin function as a JACK application.")
     (name "ladspa")
     (version "1.13")
     (source (origin
-             (method url-fetch)
-             (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
-                   version
-                   ".tgz"))
-             (sha256
-              (base32
-               "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
+              (method url-fetch)
+              ;; The domain ladspa.org seems to be no longer under the control
+              ;; of the LADSPA project.
+              (uri (string-append
+                    "http://web.archive.org/web/20150426155900/"
+                    "http://www.ladspa.org/download/ladspa_sdk.tgz"))
+              (sha256
+               (base32
+                "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f  ; the "test" target is a listening test only
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-11-16 19:33 [PATCH] Replace broken LADSPA URL Ricardo Wurmus
@ 2015-11-17  8:45 ` Alex Kost
  2015-11-17  9:47   ` Ricardo Wurmus
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Kost @ 2015-11-17  8:45 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel@gnu.org

Ricardo Wurmus (2015-11-16 22:33 +0300) wrote:

> The ladspa.org domain appears to be no longer under control of the
> LADSPA project (does it still exist?).
>
> The attached patch changes the source URL such that it downloads the
> last copy archived by http://web.archive.org.  Is this okay or should we
> look for a more permanent home for the LADSPA sources?

Alex Vong already suggested a patch for LADSPA home page and origin:
<http://lists.gnu.org/archive/html/guix-devel/2015-11/msg00356.html>.

I also wonder about the policy to replace dead URLs.  Should it be
web-archive, or debian/slackware/... mirrors?

-- 
Alex

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-11-17  8:45 ` Alex Kost
@ 2015-11-17  9:47   ` Ricardo Wurmus
  2015-11-17 16:14     ` Ludovic Courtès
  0 siblings, 1 reply; 15+ messages in thread
From: Ricardo Wurmus @ 2015-11-17  9:47 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel@gnu.org


Alex Kost <alezost@gmail.com> writes:

>> The ladspa.org domain appears to be no longer under control of the
>> LADSPA project (does it still exist?).
>>
>> The attached patch changes the source URL such that it downloads the
>> last copy archived by http://web.archive.org.  Is this okay or should we
>> look for a more permanent home for the LADSPA sources?
>
> Alex Vong already suggested a patch for LADSPA home page and origin:
> <http://lists.gnu.org/archive/html/guix-devel/2015-11/msg00356.html>.

Oh, thanks.  I missed that.

> I also wonder about the policy to replace dead URLs.  Should it be
> web-archive, or debian/slackware/... mirrors?

I don’t know.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-11-17  9:47   ` Ricardo Wurmus
@ 2015-11-17 16:14     ` Ludovic Courtès
  2015-12-27 14:40       ` Alex Kost
  0 siblings, 1 reply; 15+ messages in thread
From: Ludovic Courtès @ 2015-11-17 16:14 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel@gnu.org, Alex Kost

Ricardo Wurmus <rekado@elephly.net> skribis:

> Alex Kost <alezost@gmail.com> writes:
>
>>> The ladspa.org domain appears to be no longer under control of the
>>> LADSPA project (does it still exist?).
>>>
>>> The attached patch changes the source URL such that it downloads the
>>> last copy archived by http://web.archive.org.  Is this okay or should we
>>> look for a more permanent home for the LADSPA sources?
>>
>> Alex Vong already suggested a patch for LADSPA home page and origin:
>> <http://lists.gnu.org/archive/html/guix-devel/2015-11/msg00356.html>.
>
> Oh, thanks.  I missed that.

Ricardo, could you incorporate some home-page as well, maybe pointing to
the archive.org copy until the project has a new home?

>> I also wonder about the policy to replace dead URLs.  Should it be
>> web-archive, or debian/slackware/... mirrors?
>
> I don’t know.

Any site holding a copy would do, but we should choose the most reliable
sites first.  So I think that would be Debian, then fossies.org, then
web.archive.org (which is reliable, but probably slow.)

It’s good to specify a list of URLs instead of just one URL in those
cases.

Thoughts?

Ludo’.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-11-17 16:14     ` Ludovic Courtès
@ 2015-12-27 14:40       ` Alex Kost
  2015-12-28  7:18         ` Alex Vong
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Kost @ 2015-12-27 14:40 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel@gnu.org

Ludovic Courtès (2015-11-17 19:14 +0300) wrote:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> Alex Kost <alezost@gmail.com> writes:
>>
>>>> The ladspa.org domain appears to be no longer under control of the
>>>> LADSPA project (does it still exist?).
>>>>
>>>> The attached patch changes the source URL such that it downloads the
>>>> last copy archived by http://web.archive.org.  Is this okay or should we
>>>> look for a more permanent home for the LADSPA sources?
>>>
>>> Alex Vong already suggested a patch for LADSPA home page and origin:
>>> <http://lists.gnu.org/archive/html/guix-devel/2015-11/msg00356.html>.
>>
>> Oh, thanks.  I missed that.
>
> Ricardo, could you incorporate some home-page as well, maybe pointing to
> the archive.org copy until the project has a new home?

Sorry for the bump, I see that we still use "http://ladspa.org".  It
should be changed to something, right?

-- 
Alex

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-27 14:40       ` Alex Kost
@ 2015-12-28  7:18         ` Alex Vong
  2015-12-28 16:07           ` Mathieu Lirzin
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Vong @ 2015-12-28  7:18 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel@gnu.org

From 5ebb7b5d1508746947006720c1e46a30f1c1c312 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Thu, 12 Nov 2015 01:19:44 +0800
Subject: [PATCH] gnu: ladspa: Update urls.

* gnu/packages/audio.scm (ladspa): Update source and home page url.

Thanks to Ricardo Wurmus for suggesting downloading the source
from Internet Archive.
---
 gnu/packages/audio.scm | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6a8347a..fd076bc 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -817,15 +817,22 @@ plugin function as a JACK application.")
   (package
     (name "ladspa")
     (version "1.13")
-    (source (origin
-             (method url-fetch)
-             (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
-                   version
-                   ".tgz"))
-             (sha256
-              (base32
-               "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
+    (source
+     (origin
+       (method url-fetch)
+       ;; Since the official link is dead,
+       ;; we download the tarball from Debian or Internet Archive.
+       (uri `(,(string-append "http://http.debian.net"
+                              "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
+                              version
+                              ".orig.tar.gz")
+              ,(string-append "https://web.archive.org/web/20140717172251/"
+                              "http://www.ladspa.org/download/ladspa_sdk_"
+                              version
+                              ".tgz")))
+       (sha256
+        (base32
+         "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f  ; the "test" target is a listening test only
@@ -843,7 +850,9 @@ plugin function as a JACK application.")
               (("^CC.*")            "CC = gcc\n")
               (("^CPP.*")           "CPP = g++\n"))))
         (alist-delete 'build %standard-phases))))
-    (home-page "http://ladspa.org")
+    ;; Since the home page is gone, we provide a link to the archived version.
+    (home-page
+     "https://web.archive.org/web/20140729190945/http://www.ladspa.org/")
     (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
     (description
      "LADSPA is a standard that allows software audio processors and effects
-- 
2.6.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-28  7:18         ` Alex Vong
@ 2015-12-28 16:07           ` Mathieu Lirzin
  2015-12-28 16:14             ` Alex Vong
  0 siblings, 1 reply; 15+ messages in thread
From: Mathieu Lirzin @ 2015-12-28 16:07 UTC (permalink / raw)
  To: Alex Vong; +Cc: guix-devel@gnu.org, Alex Kost

Hi,

Alex Vong <alexvong1995@gmail.com> writes:

>From 5ebb7b5d1508746947006720c1e46a30f1c1c312 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Thu, 12 Nov 2015 01:19:44 +0800
> Subject: [PATCH] gnu: ladspa: Update urls.
>
> * gnu/packages/audio.scm (ladspa): Update source and home page url.
>
> Thanks to Ricardo Wurmus for suggesting downloading the source
> from Internet Archive.
> ---
>  gnu/packages/audio.scm | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6a8347a..fd076bc 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
[...]
> +    (source
> +     (origin
> +       (method url-fetch)
> +       ;; Since the official link is dead,
> +       ;; we download the tarball from Debian or Internet Archive.
> +       (uri `(,(string-append "http://http.debian.net"
> +                              "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
> +                              version
> +                              ".orig.tar.gz")
> +              ,(string-append "https://web.archive.org/web/20140717172251/"
> +                              "http://www.ladspa.org/download/ladspa_sdk_"
> +                              version
> +                              ".tgz")))

When there is nothing to quote, we prefer using ‘list’ over using
‘quasiquote’ + ‘unquote’.

Thanks,

--
Mathieu Lirzin

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-28 16:07           ` Mathieu Lirzin
@ 2015-12-28 16:14             ` Alex Vong
  2015-12-28 16:21               ` Alex Vong
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Vong @ 2015-12-28 16:14 UTC (permalink / raw)
  To: Mathieu Lirzin; +Cc: guix-devel@gnu.org, Alex Kost

Mathieu Lirzin <mthl@gnu.org> writes:

> Hi,
>
> When there is nothing to quote, we prefer using ‘list’ over using
> ‘quasiquote’ + ‘unquote’.
>
Sure! I will fix that.

> Thanks,
>
> --
> Mathieu Lirzin

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-28 16:14             ` Alex Vong
@ 2015-12-28 16:21               ` Alex Vong
  2015-12-28 19:29                 ` Ricardo Wurmus
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Vong @ 2015-12-28 16:21 UTC (permalink / raw)
  To: Mathieu Lirzin; +Cc: guix-devel@gnu.org, Alex Kost

From 2feefc6fd7162d7226015aa296ace0c8e7d034bf Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Thu, 12 Nov 2015 01:19:44 +0800
Subject: [PATCH] gnu: ladspa: Update urls.

* gnu/packages/audio.scm (ladspa): Update source and home page url.

Thanks to Ricardo Wurmus for suggesting downloading the source
from Internet Archive.
---
 gnu/packages/audio.scm | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6a8347a..9f3c217 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -817,15 +817,22 @@ plugin function as a JACK application.")
   (package
     (name "ladspa")
     (version "1.13")
-    (source (origin
-             (method url-fetch)
-             (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
-                   version
-                   ".tgz"))
-             (sha256
-              (base32
-               "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
+    (source
+     (origin
+       (method url-fetch)
+       ;; Since the official link is dead,
+       ;; we download the tarball from Debian or Internet Archive.
+       (uri (list (string-append "http://http.debian.net"
+                                 "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
+                                 version
+                                 ".orig.tar.gz")
+                  (string-append "https://web.archive.org/web/20140717172251/"
+                                 "http://www.ladspa.org/download/ladspa_sdk_"
+                                 version
+                                 ".tgz")))
+       (sha256
+        (base32
+         "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f  ; the "test" target is a listening test only
@@ -843,7 +850,9 @@ plugin function as a JACK application.")
               (("^CC.*")            "CC = gcc\n")
               (("^CPP.*")           "CPP = g++\n"))))
         (alist-delete 'build %standard-phases))))
-    (home-page "http://ladspa.org")
+    ;; Since the home page is gone, we provide a link to the archived version.
+    (home-page
+     "https://web.archive.org/web/20140729190945/http://www.ladspa.org/")
     (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
     (description
      "LADSPA is a standard that allows software audio processors and effects
-- 
2.6.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-28 16:21               ` Alex Vong
@ 2015-12-28 19:29                 ` Ricardo Wurmus
  2015-12-28 22:24                   ` Alex Kost
  2015-12-29 13:15                   ` Alex Vong
  0 siblings, 2 replies; 15+ messages in thread
From: Ricardo Wurmus @ 2015-12-28 19:29 UTC (permalink / raw)
  To: Alex Vong; +Cc: guix-devel@gnu.org, Alex Kost


Alex Vong <alexvong1995@gmail.com> writes:

> From 2feefc6fd7162d7226015aa296ace0c8e7d034bf Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Thu, 12 Nov 2015 01:19:44 +0800
> Subject: [PATCH] gnu: ladspa: Update urls.
>
> * gnu/packages/audio.scm (ladspa): Update source and home page url.
>
> Thanks to Ricardo Wurmus for suggesting downloading the source
> from Internet Archive.

Thanks, but attribution is not required here :)

>  gnu/packages/audio.scm | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6a8347a..9f3c217 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -817,15 +817,22 @@ plugin function as a JACK application.")
>    (package
>      (name "ladspa")
>      (version "1.13")
> -    (source (origin
> -             (method url-fetch)
> -             (uri (string-append
> -                   "http://www.ladspa.org/download/ladspa_sdk_"
> -                   version
> -                   ".tgz"))
> -             (sha256
> -              (base32
> -               "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
> +    (source
> +     (origin
> +       (method url-fetch)
> +       ;; Since the official link is dead,
> +       ;; we download the tarball from Debian or Internet Archive.
> +       (uri (list (string-append "http://http.debian.net"
> +                                 "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
> +                                 version
> +                                 ".orig.tar.gz")

My preference is to keep “version” and the following string on the same
line because they are both short.

> +                  (string-append "https://web.archive.org/web/20140717172251/"
> +                                 "http://www.ladspa.org/download/ladspa_sdk_"
> +                                 version
> +                                 ".tgz")))

Same here.  (It’s just a nitpick.)

> +       (sha256
> +        (base32
> +         "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
>      (build-system gnu-build-system)
>      (arguments
>       `(#:tests? #f  ; the "test" target is a listening test only
> @@ -843,7 +850,9 @@ plugin function as a JACK application.")
>                (("^CC.*")            "CC = gcc\n")
>                (("^CPP.*")           "CPP = g++\n"))))
>          (alist-delete 'build %standard-phases))))
> -    (home-page "http://ladspa.org")
> +    ;; Since the home page is gone, we provide a link to the archived version.
> +    (home-page
> +     "https://web.archive.org/web/20140729190945/http://www.ladspa.org/")
>      (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
>      (description
>       "LADSPA is a standard that allows software audio processors and effects

Do you have permission to push or should I apply this on your behalf?

~~ Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-28 19:29                 ` Ricardo Wurmus
@ 2015-12-28 22:24                   ` Alex Kost
  2015-12-29 13:17                     ` Alex Vong
  2015-12-29 13:15                   ` Alex Vong
  1 sibling, 1 reply; 15+ messages in thread
From: Alex Kost @ 2015-12-28 22:24 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel@gnu.org

Ricardo Wurmus (2015-12-28 22:29 +0300) wrote:

> Alex Vong <alexvong1995@gmail.com> writes:
>
[...]
>> +     (origin
>> +       (method url-fetch)
>> +       ;; Since the official link is dead,
>> +       ;; we download the tarball from Debian or Internet Archive.
>> +       (uri (list (string-append "http://http.debian.net"
>> +                                 "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
>> +                                 version
>> +                                 ".orig.tar.gz")
>
> My preference is to keep “version” and the following string on the same
> line because they are both short.

Oh, yes, yes, I totally agree!  I always find it odd when the lines are
split like this.

-- 
Alex

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-28 19:29                 ` Ricardo Wurmus
  2015-12-28 22:24                   ` Alex Kost
@ 2015-12-29 13:15                   ` Alex Vong
  2015-12-29 16:04                     ` Mathieu Lirzin
  1 sibling, 1 reply; 15+ messages in thread
From: Alex Vong @ 2015-12-29 13:15 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: guix-devel@gnu.org, Alex Kost

Ricardo Wurmus <rekado@elephly.net> writes:

> Alex Vong <alexvong1995@gmail.com> writes:
>
>> From 2feefc6fd7162d7226015aa296ace0c8e7d034bf Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Thu, 12 Nov 2015 01:19:44 +0800
>> Subject: [PATCH] gnu: ladspa: Update urls.
>>
>> * gnu/packages/audio.scm (ladspa): Update source and home page url.
>>
>> Thanks to Ricardo Wurmus for suggesting downloading the source
>> from Internet Archive.
>
> Thanks, but attribution is not required here :)
>
OK...

>>  gnu/packages/audio.scm | 29 +++++++++++++++++++----------
>>  1 file changed, 19 insertions(+), 10 deletions(-)
>>
>> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
>> index 6a8347a..9f3c217 100644
>> --- a/gnu/packages/audio.scm
>> +++ b/gnu/packages/audio.scm
>> @@ -817,15 +817,22 @@ plugin function as a JACK application.")
>>    (package
>>      (name "ladspa")
>>      (version "1.13")
>> -    (source (origin
>> -             (method url-fetch)
>> -             (uri (string-append
>> -                   "http://www.ladspa.org/download/ladspa_sdk_"
>> -                   version
>> -                   ".tgz"))
>> -             (sha256
>> -              (base32
>> -               "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       ;; Since the official link is dead,
>> +       ;; we download the tarball from Debian or Internet Archive.
>> +       (uri (list (string-append "http://http.debian.net"
>> +                                 "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
>> +                                 version
>> +                                 ".orig.tar.gz")
>
> My preference is to keep “version” and the following string on the same
> line because they are both short.
>
Is it a lisp / scheme convention to do this? I always think I should
call a function like this:
(func arg1 arg2 ...)
or
(func arg1
      arg2
      ...)

>> + (string-append "https://web.archive.org/web/20140717172251/"
>> +                                 "http://www.ladspa.org/download/ladspa_sdk_"
>> +                                 version
>> +                                 ".tgz")))
>
> Same here.  (It’s just a nitpick.)
>
>> +       (sha256
>> +        (base32
>> +         "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
>>      (build-system gnu-build-system)
>>      (arguments
>>       `(#:tests? #f  ; the "test" target is a listening test only
>> @@ -843,7 +850,9 @@ plugin function as a JACK application.")
>>                (("^CC.*")            "CC = gcc\n")
>>                (("^CPP.*")           "CPP = g++\n"))))
>>          (alist-delete 'build %standard-phases))))
>> -    (home-page "http://ladspa.org")
>> +    ;; Since the home page is gone, we provide a link to the archived version.
>> +    (home-page
>> +     "https://web.archive.org/web/20140729190945/http://www.ladspa.org/")
>>      (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
>>      (description
>>       "LADSPA is a standard that allows software audio processors and effects
>
> Do you have permission to push or should I apply this on your behalf?
>
No, I don't have push right. I am more of a user-programmer right now :)

> ~~ Ricardo

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-28 22:24                   ` Alex Kost
@ 2015-12-29 13:17                     ` Alex Vong
  2015-12-30 17:19                       ` Ludovic Courtès
  0 siblings, 1 reply; 15+ messages in thread
From: Alex Vong @ 2015-12-29 13:17 UTC (permalink / raw)
  To: Alex Kost; +Cc: guix-devel@gnu.org

From 40f8a47fa189398a094e4f4d2bc2e78d0496b633 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995@gmail.com>
Date: Thu, 12 Nov 2015 01:19:44 +0800
Subject: [PATCH] gnu: ladspa: Update urls.

* gnu/packages/audio.scm (ladspa): Update source and home page url.
---
 gnu/packages/audio.scm | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6a8347a..c242f25 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -817,15 +817,20 @@ plugin function as a JACK application.")
   (package
     (name "ladspa")
     (version "1.13")
-    (source (origin
-             (method url-fetch)
-             (uri (string-append
-                   "http://www.ladspa.org/download/ladspa_sdk_"
-                   version
-                   ".tgz"))
-             (sha256
-              (base32
-               "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
+    (source
+     (origin
+       (method url-fetch)
+       ;; Since the official link is dead,
+       ;; we download the tarball from Debian or Internet Archive.
+       (uri (list (string-append "http://http.debian.net"
+                                 "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
+                                 version ".orig.tar.gz")
+                  (string-append "https://web.archive.org/web/20140717172251/"
+                                 "http://www.ladspa.org/download/ladspa_sdk_"
+                                 version ".tgz")))
+       (sha256
+        (base32
+         "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f  ; the "test" target is a listening test only
@@ -843,7 +848,9 @@ plugin function as a JACK application.")
               (("^CC.*")            "CC = gcc\n")
               (("^CPP.*")           "CPP = g++\n"))))
         (alist-delete 'build %standard-phases))))
-    (home-page "http://ladspa.org")
+    ;; Since the home page is gone, we provide a link to the archived version.
+    (home-page
+     "https://web.archive.org/web/20140729190945/http://www.ladspa.org/")
     (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
     (description
      "LADSPA is a standard that allows software audio processors and effects
-- 
2.6.3

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-29 13:15                   ` Alex Vong
@ 2015-12-29 16:04                     ` Mathieu Lirzin
  0 siblings, 0 replies; 15+ messages in thread
From: Mathieu Lirzin @ 2015-12-29 16:04 UTC (permalink / raw)
  To: Alex Vong; +Cc: guix-devel@gnu.org, Alex Kost

Alex Vong <alexvong1995@gmail.com> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Alex Vong <alexvong1995@gmail.com> writes:
[...]
>>> +       (uri (list (string-append "http://http.debian.net"
>>> +                                 "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
>>> +                                 version
>>> +                                 ".orig.tar.gz")
>>
>> My preference is to keep “version” and the following string on the same
>> line because they are both short.
>>
> Is it a lisp / scheme convention to do this? I always think I should
> call a function like this:
> (func arg1 arg2 ...)
> or
> (func arg1
>       arg2
>       ...)
>

You are right.  What you have described is the general rule.
Nonetheless in the case of ‘string-append’, some of us like to make an
exception probably because the general rule wastes a lot of lines
without improving clarity.

--
Mathieu Lirzin

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH] Replace broken LADSPA URL.
  2015-12-29 13:17                     ` Alex Vong
@ 2015-12-30 17:19                       ` Ludovic Courtès
  0 siblings, 0 replies; 15+ messages in thread
From: Ludovic Courtès @ 2015-12-30 17:19 UTC (permalink / raw)
  To: Alex Vong; +Cc: guix-devel@gnu.org, Alex Kost

Alex Vong <alexvong1995@gmail.com> skribis:

> From 40f8a47fa189398a094e4f4d2bc2e78d0496b633 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Thu, 12 Nov 2015 01:19:44 +0800
> Subject: [PATCH] gnu: ladspa: Update urls.
>
> * gnu/packages/audio.scm (ladspa): Update source and home page url.

Applied, thanks!

Ludo’.

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2015-12-30 17:19 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-16 19:33 [PATCH] Replace broken LADSPA URL Ricardo Wurmus
2015-11-17  8:45 ` Alex Kost
2015-11-17  9:47   ` Ricardo Wurmus
2015-11-17 16:14     ` Ludovic Courtès
2015-12-27 14:40       ` Alex Kost
2015-12-28  7:18         ` Alex Vong
2015-12-28 16:07           ` Mathieu Lirzin
2015-12-28 16:14             ` Alex Vong
2015-12-28 16:21               ` Alex Vong
2015-12-28 19:29                 ` Ricardo Wurmus
2015-12-28 22:24                   ` Alex Kost
2015-12-29 13:17                     ` Alex Vong
2015-12-30 17:19                       ` Ludovic Courtès
2015-12-29 13:15                   ` Alex Vong
2015-12-29 16:04                     ` Mathieu Lirzin

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).