From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Export udev-configuration functions.
Date: Thu, 19 Nov 2015 17:08:45 +0100
Message-ID: <87ziyahsz6.fsf@elephly.net>
References: <874mgjk0ip.fsf@elephly.net> <87610zp4wg.fsf@gnu.org>
	<87bnarj9zf.fsf@elephly.net> <87h9kjhu95.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZzRld-0001K3-4e
	for guix-devel@gnu.org; Thu, 19 Nov 2015 11:09:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZzRlc-0005xG-8a
	for guix-devel@gnu.org; Thu, 19 Nov 2015 11:09:01 -0500
In-reply-to: <87h9kjhu95.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Courtès <ludo@gnu.org> writes:

>> From 77f22cb933a9740cccc62f6bac2d3f9381192eba Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Wed, 18 Nov 2015 21:58:53 +0100
>> Subject: [PATCH] services: Add udev-rule procedure.
>>
>> * gnu/services/base.scm (udev-rule): New procedure.
>> (kvm-udev-rule): Rewrite in terms of udev-rule.
>
> [...]
>
>> +(define (udev-rule filename contents)
>> +  "Return a directory with a udev rule file FILENAME containing CONTENTS."
>
> Rather “file-name” (sorry for being pedantic ;-)).

Okay.

>> +(define (kvm-udev-rule)
>
> This can even become a plain variable.

Okay!

> Otherwise LGTM!

Thanks.  I pushed it with these two changes.

~~ Ricardo