From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Wingo Subject: Re: [PATCH 01/10] gnu: cross: Use CROSS_*_INCLUDE_PATH for system headers. Date: Mon, 02 May 2016 10:04:46 +0200 Message-ID: <87zis8naw1.fsf@igalia.com> References: <1461942751-23883-1-git-send-email-janneke@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ax8ra-0006yM-Qj for guix-devel@gnu.org; Mon, 02 May 2016 04:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ax8rP-0001ms-0J for guix-devel@gnu.org; Mon, 02 May 2016 04:05:49 -0400 In-Reply-To: <1461942751-23883-1-git-send-email-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Fri, 29 Apr 2016 17:12:22 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Jan Nieuwenhuizen Cc: guix-devel@gnu.org On Fri 29 Apr 2016 17:12, Jan Nieuwenhuizen writes: > * gnu/packages/patches/gcc-cross-environment-variables.patch: Also use CROSS_ > variants: CROSS_C_INCLUDE_PATH, CROSS_CPLUS_INCLUDE_PATH, > CROSS_OBJC_INCLUDE_PATH, CROSS_OBJCPLUS_INCLUDE_PATH to be used for system > libraries, see > https://lists.gnu.org/archive/html/guix-devel/2016-04/msg00620.html. > * gnu/packages/cross-base.scm (cross-gcc, cross-gcc-arguments, cross-libc): > Use CROSS_*_INCLUDE_PATH (WAS: CPATH). > --- LGTM, for what it's worth. I get lost in the patches-to-patches part of the mail but it does not seem to be incorrect. One final ignorant question: there really is no way to do this without patching GCC? And why just one CROSS_C_INCLUDE_PATH -- would it not be necessary in theory to have such a CROSS_ARCH_... for each ARCH that we might be interested in? I am not suggesting that you make the change now but I want to know what the right thing is :) Andy