From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] Add thinkfan.
Date: Mon, 09 May 2016 10:31:46 +0200
Message-ID: <87zirzzl71.fsf@gnu.org>
References: <87mvoay9wo.fsf@saiph.selenimh> <20160501211418.GA10221@jasmine>
	<877ffalrj3.fsf@saiph.selenimh> <20160506181314.GB2123@jasmine>
	<87mvo2bvoh.fsf@saiph.selenimh> <20160507025858.GA25133@jasmine>
	<87eg9eb3ns.fsf@saiph.selenimh>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1azgbb-0003n3-Qv
	for guix-devel@gnu.org; Mon, 09 May 2016 04:31:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1azgbV-0003Ne-Sf
	for guix-devel@gnu.org; Mon, 09 May 2016 04:31:54 -0400
In-Reply-To: <87eg9eb3ns.fsf@saiph.selenimh> (Nicolas Goaziou's message of
	"Sat, 07 May 2016 11:47:35 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: guix-devel@gnu.org

Hi!

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Sat, May 07, 2016 at 01:42:22AM +0200, Nicolas Goaziou wrote:
>>> Hello,
>>>=20
>>> Leo Famulari <leo@famulari.name> writes:
>>>=20
>>> > Looks good! But I noticed they *just* released a new version. Can you
>>> > take a look and submit a patch with that version if it works for you?
>>>=20
>>> Here it is.
>>
>>> * gnu/packages/linux.scm (thinkfan): New variable.
>>
>> Thanks! Applied as d17ae8c0c30.
>
> Thank you.
>
> I realize there are hard-coded paths in init scripts. Would it make
> sense to patch them so as to refer to `thinkfan' in store instead of
> "/usr/sbin/thinkfan"?

Yes, I think so.

Ludo=E2=80=99.