From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: libgit2,
	libgit2-glib: pkg-config file: dependencies on other libraries: how
	to represent them in Guix?
Date: Sun, 19 Jun 2016 15:53:36 +0200
Message-ID: <87ziqhz3mn.fsf@gnu.org>
References: <20160617195657.38541268@scratchpost.org>
	<8760t77xbs.fsf@elephly.net> <20160618111037.2ae345d0@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bEdAX-00084b-FN
	for guix-devel@gnu.org; Sun, 19 Jun 2016 09:53:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bEdAS-0005j8-73
	for guix-devel@gnu.org; Sun, 19 Jun 2016 09:53:44 -0400
In-Reply-To: <20160618111037.2ae345d0@scratchpost.org> (Danny Milosavljevic's
	message of "Sat, 18 Jun 2016 11:10:37 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> On Sat, 18 Jun 2016 09:47:19 +0200
> Ricardo Wurmus <rekado@elephly.net> wrote:
>
>> This depends on the pkg-config file that the library installs.  If this
>> file contains a section that lists other libraries as private, then
>> propagation is probably the correct approach.
>
> See <https://github.com/libgit2/libgit2/blob/master/libgit2.pc.in>
>
> Name: libgit2
> Description: The git library, take 2
> Version: @LIBGIT2_VERSION_STRING@
>
> Libs: -L"${libdir}" -lgit2
> Libs.private: @LIBGIT2_PC_LIBS@
> Requires.private: @LIBGIT2_PC_REQUIRES@
>
> Cflags: -I${includedir}
>
> And in the CMakeLists.txt :
>
> 	IF (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
> 		LIST(APPEND LIBGIT2_PC_LIBS "-lssl")
> 	ELSE()
> 		SET(LIBGIT2_PC_REQUIRES "${LIBGIT2_PC_REQUIRES} openssl")
> 	ENDIF ()
>
> So I take it that it should have been a propagated-input in libgit2 itsel=
f already, right?

Yes.  OTOH, =E2=80=9CRequires.private=E2=80=9D is used only when static lin=
king; are we
using static linking here?  If not, we could leave it as is.

Thanks,
Ludo=E2=80=99.