From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] Fix artanis paths
Date: Tue, 09 Aug 2016 23:42:37 -0400
Message-ID: <87ziolxpaq.fsf@netris.org>
References: <86eg5yg62o.fsf@itorres.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bXKPv-0007Na-Pn
	for guix-devel@gnu.org; Tue, 09 Aug 2016 23:42:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bXKPr-0001nX-M5
	for guix-devel@gnu.org; Tue, 09 Aug 2016 23:42:54 -0400
Received: from world.peace.net ([50.252.239.5]:60084)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1bXKPr-0001nT-Hs
	for guix-devel@gnu.org; Tue, 09 Aug 2016 23:42:51 -0400
In-Reply-To: <86eg5yg62o.fsf@itorres.net> (Ignacio Torres Masdeu's message of
	"Tue, 09 Aug 2016 02:05:19 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ignacio Torres Masdeu <i@itorres.net>
Cc: guix-devel@gnu.org

Ignacio Torres Masdeu <i@itorres.net> writes:

> The last patch[1] for artanis added the DESTDIR path to place files in
> $DESTDIR/etc.
>
> [1] http://lists.gnu.org/archive/html/guix-devel/2016-03/msg00813.html
>
> This didn't account for the fact that $DESTDIR is used in the build
> system install process as a prefix for other files and the effect was
> that those files were effectively copied in $out/$out/{bin/share}:

In general, we should be setting PREFIX to $out (i.e. /gnu/store/...),
and leaving DESTDIR unset.  Conventionally, these two variables have
different meanings: PREFIX is where the files are expected to be when
the code is run.  DESTDIR is meant as a temporary staging area when
building a package, with the expectation that it will be packed up into
a binary package and later extracted into PREFIX.  So, with this in
mind:

> +         (list (string-append "MOD_PATH=" mod_dir)
> +               (string-append "MOD_COMPILED_PATH=" mod_dir)
> +               "PREFIX="
>                 (string-append "DESTDIR=" out)))

I think that this should be (string-append "PREFIX=" out) and DESTDIR
should be left unset.

I haven't looked at the details of this package, or tried to build it,
but I'd like to see a solution that follows the conventions above, if
possible.  Would you be willing to try this?

Thanks for your efforts!

      Mark