Re: [PATCH 05/24] gnu: xml: Add yaml-cpp.

[Alex Kost <alezost@gmail.com>]

David Craven (2016-08-16 21:39 +0300) wrote:

> * gnu/packages/xml.scm (yaml-cpp): New variable.
> ---
>  gnu/packages/xml.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index cfdc6c0..660a0b9 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -12,6 +12,7 @@
>  ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
>  ;;; Copyright © 2016 Ben Woodcroft <donttrustben@gmail.com>
>  ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
> +;;; Copyright © 2016 David Craven <david@craven.ch>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -31,6 +32,7 @@
>  (define-module (gnu packages xml)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages boost)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages gnupg)
>    #:use-module (gnu packages perl)
> @@ -808,3 +810,25 @@ XSLT and EXSLT.")
>  XLSM) format spreadsheets into plaintext @dfn{comma separated values} (CSV)
>  files.  It is designed to be fast and to handle large input files.")
>      (license license:gpl2+)))
> +
> +(define-public yaml-cpp
> +  (package
> +    (name "yaml-cpp")
> +    (version "0.5.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                "https://github.com/jbeder/yaml-cpp/archive/"
> +                "yaml-cpp-" version ".tar.gz"))

Please indent string-append like this:

                 (uri (string-append
                       "https://github.com/jbeder/yaml-cpp/archive/"
                       "yaml-cpp-" version ".tar.gz"))

> +              (sha256
> +               (base32
> +                "1vk6pjh0f5k6jwk2sszb9z5169whmiha9ainbdpa1arxlkq7v3b6"))))
> +    (build-system cmake-build-system)
> +    (inputs
> +     `(("boost" ,boost)))
> +    (native-inputs
> +     `(("python" ,python)))
> +    (home-page "https://github.com/jbeder/yaml-cpp")
> +    (synopsis "YAML parser and emitter in C++ matching the YAML 1.2 spec")

I would simplify the synopsis a bit: "YAML parser and emitter in C++"
(just because I don't like when synopsis and description are the same :-))

> +    (description "YAML parser and emitter in C++ matching the YAML 1.2 spec.")
> +    (license license:bsd-3)))

-- 
Alex