From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 1/3] gnu: Add cfitsio Date: Wed, 31 Aug 2016 09:45:54 +0300 Message-ID: <87zinte8rh.fsf@gmail.com> References: <1472584872-19300-1-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bezHb-0002LA-QS for guix-devel@gnu.org; Wed, 31 Aug 2016 02:46:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bezHX-000859-Hr for guix-devel@gnu.org; Wed, 31 Aug 2016 02:45:59 -0400 In-Reply-To: <1472584872-19300-1-git-send-email-jmd@gnu.org> (John Darrington's message of "Tue, 30 Aug 2016 21:21:10 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org John Darrington (2016-08-30 22:21 +0300) wrote: > * gnu/packages/astronomy.scm: New file. > * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. > --- > gnu/local.mk | 1 + > gnu/packages/astronomy.scm | 53 ++++++++++++++++++++++++++++++++++++++++= ++++++ > 2 files changed, 54 insertions(+) > create mode 100644 gnu/packages/astronomy.scm > > > diff --git a/gnu/local.mk b/gnu/local.mk > index d75ab54..26c4151 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -42,6 +42,7 @@ GNU_SYSTEM_MODULES =3D \ > %D%/packages/apr.scm \ > %D%/packages/aspell.scm \ > %D%/packages/assembly.scm \ > + %D%/packages/astronomy.scm \ > %D%/packages/attr.scm \ > %D%/packages/audacity.scm \ > %D%/packages/audio.scm \ > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > new file mode 100644 > index 0000000..881e549 > --- /dev/null > +++ b/gnu/packages/astronomy.scm > @@ -0,0 +1,53 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2016 John Darrington > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify it > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages astronomy) > + #:use-module (guix packages) > + #:use-module (guix licenses) > + #:use-module (guix download) > + #:use-module (guix build-system gnu)) > + > +(define-public cfitsio > + (package > + (name "cfitsio") > + (version "3390") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/" name versi= on > + ".tar.gz"))=20 ^ Please indent the above lines properly and remove the trailing space, I would write it like this: (uri (string-append "http://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/" name version ".tar.gz")) > + (sha256 > + (base32 "02gllydm63irwbqqisa3mrskw1fphm5rlplglz3mq9whi3rxilv2"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; no tests > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'replace-slash-bin > + (lambda _ > + (substitute* "Makefile.in" (("/bin/") ""))))))) Please add #t in the end of this phase. > + (home-page "http://heasarc.gsfc.nasa.gov/fitsio/fitsio.html") > + (synopsis "Library for reading and writing FITS files") > + (description "CFITSIO provides simple high-level routines for readin= g and > +writing FITS (Flexible Image Transport System) files that insulate the > +programmer from the internal complexities of the FITS format. CFITSIO al= so > +provides many advanced features for manipulating and filtering the infor= mation > +in FITS files.") > + (license (license:non-copyleft "file://License.txt" > + "See License.txt in the distribution.")))) ^^^^^^^^^ Indentation here --=20 Alex