From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH 8/9] services: Add sddm service.
Date: Fri, 02 Sep 2016 20:26:05 +0800
Message-ID: <87zinqsd2a.fsf@member.fsf.org>
References: <20160901155711.7388-1-david@craven.ch>
	<20160901155711.7388-8-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1bfnXs-00074W-Sq
	for guix-devel@gnu.org; Fri, 02 Sep 2016 08:26:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1bfnXn-0002vR-Rb
	for guix-devel@gnu.org; Fri, 02 Sep 2016 08:26:07 -0400
Received: from smtp11.openmailbox.org ([62.4.1.45]:35464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1bfnXn-0002vH-Lr
	for guix-devel@gnu.org; Fri, 02 Sep 2016 08:26:03 -0400
In-Reply-To: <20160901155711.7388-8-david@craven.ch> (David Craven's message
	of "Thu, 1 Sep 2016 17:57:10 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

[...]
> +
> +(define (sddm-activation config)
> +  "Return the activation gexp for CONFIG."
> +  #~(begin
> +      (symlink #$(sddm-configuration-file config) "/etc/sddm.conf")))

I don't know the behavior of activation when reconfigure services,
but this `symlink' call will fail when the file already exists.

And to put files to /etc, it's better to extend the `etc-service-type'.


Oh, finally we get a modern display manager, thanks!