From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add scratch Date: Mon, 05 Sep 2016 22:06:49 +0200 Message-ID: <87zinmxg9y.fsf@gnu.org> References: <87lgzjzuea.fsf@saiph.selenimh> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bh0AT-0003mh-PA for guix-devel@gnu.org; Mon, 05 Sep 2016 16:06:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bh0AP-0006Bz-Fi for guix-devel@gnu.org; Mon, 05 Sep 2016 16:06:56 -0400 In-Reply-To: <87lgzjzuea.fsf@saiph.selenimh> (Nicolas Goaziou's message of "Fri, 02 Sep 2016 19:28:13 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Nicolas Goaziou Cc: guix-devel@gnu.org Hi Nicolas, Nicolas Goaziou skribis: > The following patch adds Scratch to the Guix packages. Woohoo, nice work! > There are some caveats: > > - it is not the latest version of scratch (1.4 instead of 2.0) as this > one required Adobe Air for the offline editor and Flash plugin online. Yeah. :-/ > - it freezes when returning from fullscreen execution of a script. Note > that the same happens with the Debian package, so there's probably > little I can do. OK. > - the installation merely copies Scratch.image, which is an image of the > VM. It is not a binary blob. You can inspect and modify code from > within the application. See > for details. I=E2=80=99m not too familiar with Smalltalk, but still, a VM image is a bin= ary, right? It=E2=80=99s a binary that may contain source code, but it=E2=80=99= s a binary. Can it be reproduced? > - "/usr/share/scratch" directory is hard-coded. As a consequence Scratch > cannot find translation files or artwork. You can still import artwork > from the store directory but it is not a great out-of-the box > experience. > > I notified the issue to the developers > (https://github.com/LLK/Scratch_1.4/issues) but, considering other > issues there are years old, I have little hope about it. > > If there's an idea on how to fake the "/usr/share/scratch" directory, > I'm all ears. It=E2=80=99s hard-coded in the VM image, right? If we could rebuild the VM image =E2=80=9Cfrom source=E2=80=9D, then we could easily change this file = name. Otherwise we probably have to fiddle with the binary, but since our own directory name is going to be longer, this is probably not possible. Some minor comments: > + (description "Scratch is an easy, interactive, collaborative > +programming environment designed for creation of interactive stories, > +animations, games, music, and art -- and sharing these on the web. For an em dash, write =E2=80=9Cart---and sharing=E2=80=9D (info "(texinfo) = Conventions"). > + (home-page "http://scratch.mit.edu") > + ;; Source is GPL2 licensed, Plugins are MIT licensed and Artwork (sp= rites, > + ;; backgrounds, sounds...) is CC-BY-SA3.0 licensed. > + (license (list license:gpl2 license:x11 license:cc-by-sa3.0)))) So GPLv2-only and X11 (not Expat), right? Just to make sure. :-) > diff --git a/gnu/packages/patches/scratch-desktopfile-semicolon.patch b/g= nu/packages/patches/scratch-desktopfile-semicolon.patch > new file mode 100644 > index 0000000..b013193 > --- /dev/null > +++ b/gnu/packages/patches/scratch-desktopfile-semicolon.patch Please add a line at the beginning of the patch to explain what it does and what its upstream status is. Other than that it looks great. Thanks! Ludo=E2=80=99.