unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/7] gnu: Add r-rbgl.
Date: Mon, 19 Sep 2016 12:15:44 +0200	[thread overview]
Message-ID: <87zin419gv.fsf@gnu.org> (raw)
In-Reply-To: <87k2e8mc9q.fsf@elephly.net>


Ricardo Wurmus writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> * gnu/packages/bioinformatics.scm (r-rbgl): New variable.
>> ---
>>  gnu/packages/bioinformatics.scm | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>> index ffb9692..3d607cc 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -5309,6 +5309,30 @@ packages.")
>>  CRAN, and (some) github packages.")
>>      (license license:artistic2.0)))
>>  
>> +(define-public r-rbgl
>> +  (package
>> +    (name "r-rbgl")
>> +    (version "1.49.3")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append
>> +                    "https://bioconductor.org/packages/3.4/bioc/src/contrib/"
>> +                    "RBGL_" version ".tar.gz"))
>
> Shouldn’t this be “(bioconductor-uri "RBGL" version)”?

You are right, it should be “(bioconductor-uri "RBGL" version)”.

>> +              (sha256
>> +               (base32
>> +                "0rpiqpalbxk82jkwv3l0fimq9y2hrdi0f7ca4v21318541vfsncs"))))
>> +    (properties
>> +     `((upstream-name . "RBGL")))
>> +    (build-system r-build-system)
>> +    (propagated-inputs
>> +     `(("r-graph" ,r-graph)))
>> +    (home-page "http://bioconductor.org/packages/RBGL")
>> +    (synopsis "Interface to the graph algorithms from Boost")
>> +    (description
>> +     "This package provides a fairly extensive and comprehensive interface to
>> +the graph algorithms contained in the Boost library.")
>> +    (license license:artistic2.0)))
>> +
>
> This package looks very familiar.  Chances are that I packaged this
> already and forgot about it… :)

Do you whether you stripped the Boost source code in this package and
used the Boost library from Guix?  I wanted to do so, but couldn't
figure out how it gets build!  Plus, they use Boost 1.61.0 on this RBGL
release, and we are stuck at 1.60.0.

Thanks for looking at this package.

Kind regards,
Roel Janssen

  reply	other threads:[~2016-09-19 10:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 11:38 [PATCH 2/7] gnu: Add r-rbgl Roel Janssen
2016-09-19 10:09 ` Ricardo Wurmus
2016-09-19 10:15   ` Roel Janssen [this message]
2016-09-19 10:54     ` Ricardo Wurmus
2016-09-19 11:31       ` Roel Janssen
2016-09-19 13:00         ` Ricardo Wurmus
2016-09-19 13:28           ` Roel Janssen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zin419gv.fsf@gnu.org \
    --to=roel@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).