From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: Cosmetical change: remove inconsistent "$file ends here"? Date: Sun, 25 Sep 2016 09:21:38 +0000 Message-ID: <87zimws5b1.fsf@we.make.ritual.n0.is> References: <871t09t6f1.fsf@we.make.ritual.n0.is> <87a8ewl6tq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bo5dD-0000UV-Cj for guix-devel@gnu.org; Sun, 25 Sep 2016 05:21:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bo5d8-00016u-CW for guix-devel@gnu.org; Sun, 25 Sep 2016 05:21:55 -0400 Received: from aibo.runbox.com ([91.220.196.211]:43764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bo5d8-00015Q-5f for guix-devel@gnu.org; Sun, 25 Sep 2016 05:21:50 -0400 In-Reply-To: <87a8ewl6tq.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost writes: > ng0 (2016-09-24 20:00 +0000) wrote: > >> We should either be consistent with this in all files or remove this >> altogether in my opinion. >> >>> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here" >>> gnu/build/vm.scm:323:;;; vm.scm ends here > ... >> What do you think? > > I don't know what the original purpose of this convention is, it was > probably invented in those ancient times when dinosaurs walked by > streets, but I kinda like these "ends here" things :-) > > The only purpose I see in using them: you can be sure that there will > not appear redundant newlines (introduced by untidy commits) in the end > of files. > > Anyway, I vote for leaving them and adding the missing ones. Okay, with your explanation this is the more reasonable thing to do. > -- > Alex > -- ng0