From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] add kobodeluxe Date: Mon, 17 Oct 2016 16:50:29 +0200 Message-ID: <87zim381xm.fsf@gnu.org> References: <87k2d7anh9.fsf@dustycloud.org> <87h98bag8p.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw9FL-00009r-CF for guix-devel@gnu.org; Mon, 17 Oct 2016 10:50:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw9FI-000066-6t for guix-devel@gnu.org; Mon, 17 Oct 2016 10:50:35 -0400 In-Reply-To: <87h98bag8p.fsf@dustycloud.org> (Christopher Allan Webber's message of "Sun, 16 Oct 2016 20:58:30 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Allan Webber Cc: guix-devel@gnu.org Hello! Welcome, Stephen! Christopher Allan Webber skribis: > From c8b122d8c7cf7a574bbbac66963ac355c64effc5 Mon Sep 17 00:00:00 2001 > From: Stephen Webber > Date: Sun, 16 Oct 2016 15:04:35 -0500 > Subject: [PATCH] gnu: Add kobodeluxe. > > * gnu/packages/games.scm (kobodeluxe): New variable. > * gnu/packages/patches/kobodeluxe_paths.patch: New file. > * gnu/packages/patches/kobodeluxe-spelling.patch: New file. > * gnu/packages/patches/kobodeluxe_enemies-pipe-decl.patch: New file. > * gnu/packages/patches/kobodeluxe_const_charp_conversion.patch: New file. > * gnu/packages/patches/kobodeluxe_manpage-minus-not-hyphen.patch: New fil= e. > * gnu/packages/patches/kobodeluxe-midicon-segmentation-fault.patch: New f= ile. > * gnu/packages/patches/kobodeluxe_graphics_window-signed-char.patch: New = file. > * gnu/local.mk (dist_patch_DATA): Register it. Overall looks good to me! I have minor/cosmetic suggestions, but otherwise this is ready for commit IMO. > + %D%/packages/patches/kobodeluxe_paths.patch > + %D%/packages/patches/kobodeluxe-spelling.patch > + %D%/packages/patches/kobodeluxe_enemies-pipe-decl.patch > + %D%/packages/patches/kobodeluxe_const_charp_conversion.patch > + %D%/packages/patches/kobodeluxe_manpage-minus-not-hyphen.patch > + %D%/packages/patches/kobodeluxe-midicon-segmentation-fault.patch > + %D%/packages/patches/kobodeluxe_graphics_window-signed-char.patch Maybe use only hyphens in file names for consistency. > + (synopsis "Shooter with space station destruction") > + (description > + "Kobo Deluxe is an enhanced version of Akira Higuchi's XKobo for Un= *x > +systems with X11.") Maybe s/XKobo.*/XKobo graphical game/. That way =E2=80=98guix package -s game=E2=80=99 will return it. :-) > --- /dev/null > +++ b/gnu/packages/patches/kobodeluxe-spelling.patch > @@ -0,0 +1,25 @@ > +Description: two spelling fixes > +Author: Damyan Ivanov Maybe this patch can be omitted; hopefully it=E2=80=99ll be fixed in the ne= xt release. > +++ b/gnu/packages/patches/kobodeluxe_paths.patch > @@ -0,0 +1,40 @@ > +# Disable reading of configs, graphics, and data from the current direct= ory. > +# So it's safe to run kobodeluxe from anywhere w/o worry about an attack= er > +# feeding it bad data. Could you indicate the origin or status of this patch? Chris: feel free to push an updated version! Stephen, you picked a tricky package as your first patch but it=E2=80=99s perfect! I=E2=80=99m sure you had a good mentor too. ;-) Ludo=E2=80=99.