From: Marius Bakke <mbakke@fastmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/4] gnu: xapian: Use 'modify-phases'.
Date: Mon, 17 Oct 2016 19:50:07 +0100 [thread overview]
Message-ID: <87zim27qu8.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20161017180015.GB31629@jasmine>
Leo Famulari <leo@famulari.name> writes:
> On Mon, Oct 17, 2016 at 05:55:05PM +0100, Marius Bakke wrote:
>> * gnu/packages/search.scm (xapian)[arguments]: Use 'modify-phases'.
>
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'patch-remotetcp-harness
>> + (lambda _
>> + (substitute* "tests/harness/backendmanager_remotetcp.cc"
>> + (("/bin/sh") (which "bash"))))))))
>
> Please change it to use (which "sh") instead. Bash changes its behavior
> based on whether it is called as `bash` or `sh` (see Invocation in
> bash(1)).
I'm aware, but decided to remove it in the subsequent patch since it was
"buggy" anyway, and is not needed when remote TCP tests are disabled.
It was left to avoid justifying the fix when changing to modify-phases.
The phase also does not end on a #t.
But I agree, might as well just fix it and leave it even if the tests
don't use it.
next prev parent reply other threads:[~2016-10-17 18:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:55 [PATCH 0/4] Notmuch and Xapian update Marius Bakke
2016-10-17 16:55 ` [PATCH 1/4] gnu: notmuch: Update to 0.23 Marius Bakke
2016-10-17 17:58 ` Leo Famulari
2016-10-17 18:43 ` Marius Bakke
2016-10-17 16:55 ` [PATCH 2/4] gnu: notmuch: Enable tests Marius Bakke
2016-10-17 18:29 ` Leo Famulari
2016-10-17 18:56 ` Marius Bakke
2016-10-17 16:55 ` [PATCH 3/4] gnu: xapian: Use 'modify-phases' Marius Bakke
2016-10-17 18:00 ` Leo Famulari
2016-10-17 18:50 ` Marius Bakke [this message]
2016-10-17 16:55 ` [PATCH 4/4] gnu: xapian: Update to 1.4.0 Marius Bakke
2016-10-17 19:49 ` Leo Famulari
2016-10-18 21:55 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zim27qu8.fsf@duckhunt.i-did-not-set--mail-host-address--so-tickle-me \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).