From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodoros Foradis Subject: Re: [PATCH v3 3/3] gnu: Add kicad. Date: Wed, 02 Nov 2016 17:42:01 +0200 Message-ID: <87zilhsxbq.fsf@openmailbox.org> References: <20161025160907.30181-1-theodoros.for@openmailbox.org> <20161025170001.2717-1-theodoros.for@openmailbox.org> <20161025170001.2717-4-theodoros.for@openmailbox.org> <20161030001838.GB15871@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1xio-0008E2-3L for guix-devel@gnu.org; Wed, 02 Nov 2016 11:45:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1xik-00051o-Us for guix-devel@gnu.org; Wed, 02 Nov 2016 11:45:02 -0400 Received: from smtp28.openmailbox.org ([62.4.1.62]:45012 helo=smtp13.openmailbox.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1xik-00051E-Mh for guix-devel@gnu.org; Wed, 02 Nov 2016 11:44:58 -0400 In-reply-to: <20161030001838.GB15871@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Guix-devel Leo Famulari writes: > On Tue, Oct 25, 2016 at 08:00:01PM +0300, Theodoros Foradis wrote: >> * gnu/packages/engineering.scm (kicad): New variable. > > Looks pretty good to me. Below are some things I would investigate and > potentially fix on my own before pushing to Savannah; no need to send a > new patch. > > Now we are just waiting to learn more about python2-wxpython... > >> +;; We use kicad from a git commit, because support for boost 1.61.0 >> +;; has been recently added. >> +(define-public kicad >> + (let ((commit "4ee344e150bfaf3a6f3f7bf935fb96ae07c423fa") >> + (revision "1")) >> + (package >> + (name "kicad") >> + (version (string-append "4.0-" revision "." >> + (string-take commit 7))) >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://git.launchpad.net/kicad.git") > > Please use the correct URL here :) > Right. Is it normal that the url is not checked again, after having the source in store? >> + #:configure-flags >> + (list "-DKICAD_STABLE_VERSION=ON" >> + "-DKICAD_REPO_NAME=stable" >> + "-DKICAD_BUILD_VERSION=4.0" > > If possible, we should use our package's version string here. We aren't > really packaging KiCad 4.0, but rather 4.0 plus some extra Git commits, > right? > Right. >> + "-DCMAKE_BUILD_TYPE=Release" >> + "-DKICAD_SKIP_BOOST=ON"; Use our system's boost library >> + "-DKICAD_SCRIPTING=ON" >> + "-DKICAD_SCRIPTING_MODULES=ON" >> + "-DKICAD_SCRIPTING_WXPYTHON=ON" >> + ;; Has to be set explicitely, as we don't have the wxPython >> + ;; headers in the wxwidgets store item, but in wxPython. >> + (string-append "-DCMAKE_CXX_FLAGS=-I" >> + (assoc-ref %build-inputs "wxpython") >> + "/include/wx-3.0") >> + "-DCMAKE_BUILD_WITH_INSTALL_RPATH=TRUE" >> + "-DBUILD_GITHUB_PLUGIN=OFF") > > I would try building with this on. Does it require some unpackaged > dependencies? It builds with this on, without extra dependencies, but the plugin doesn't work due to CA certificates errors: Reason: 'IO_ERROR: curl_easy_perform()=60: Peer certificate cannot be authenticated with given CA certificates from kicad_curl_easy.cpp : Perform() line:92' I tried setting the SSL_CERT_FILE environment variable, but still doesn't work. This plugin will most likely be unneeded anyway, after I package the libraries and footprint for guix, which should not take long. Feedback is most welcome. Regards, -- Theodoros Foradis