From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/6] gnu: Add fatfsck-static.
Date: Sun, 06 Nov 2016 22:42:39 +0100
Message-ID: <87zilcwai8.fsf@gnu.org>
References: <20161105125511.29383-1-mbakke@fastmail.com>
	<20161105125511.29383-2-mbakke@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c3VDB-0004Z6-3l
	for guix-devel@gnu.org; Sun, 06 Nov 2016 16:42:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c3VD8-0002Qu-1V
	for guix-devel@gnu.org; Sun, 06 Nov 2016 16:42:45 -0500
In-Reply-To: <20161105125511.29383-2-mbakke@fastmail.com> (Marius Bakke's
	message of "Sat, 5 Nov 2016 12:55:06 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/disk.scm (dosfstools/static): New private variable.
> (fatfsck/static): New variable.

You could add =E2=80=9C#:allowed-references ()=E2=80=9D in =E2=80=98fatfsck=
/static=E2=80=99 to make sure
it doesn=E2=80=99t retain references to anything else.

> +    (description "This package provides a statically-linked fsck.fat
> +and a fsck.vfat compatibility symlink for use in an initrd.")

@command{fsck.fat} etc.

Otherwise LGTM, thanks!

Ludo=E2=80=99.