From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] import: cpan: Add CPAN updater.
Date: Wed, 07 Dec 2016 12:02:35 +0100
Message-ID: <87zik880j8.fsf@gnu.org>
References: <20161205050317.13222-1-bavier@member.fsf.org>
	<20161205050317.13222-2-bavier@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cEZzl-0007F6-KS
	for guix-devel@gnu.org; Wed, 07 Dec 2016 06:02:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cEZzi-00026Z-Bf
	for guix-devel@gnu.org; Wed, 07 Dec 2016 06:02:41 -0500
In-Reply-To: <20161205050317.13222-2-bavier@member.fsf.org> (Eric Bavier's
	message of "Sun, 4 Dec 2016 23:03:17 -0600")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Eric Bavier <bavier@member.fsf.org>
Cc: guix-devel@gnu.org

Eric Bavier <bavier@member.fsf.org> skribis:

> * guix/import/cpan.scm (module->dist-name): Fetch the field of interest.
> (cpan-fetch): Accept release name rather than module name.
> (fix-source-url): Rename to ...
> (cpan-source-url): ... this.  Take metadata as parameter.
> (cpan-module->sexp): Move local core-module? procedure to ...
> (core-module?): ... here.
> (package->upstream-name, cpan-version, cpan-package?, latest-release):
> New procedures.
> (%cpan-updater): New variable.
> * guix/scripts/refresh.scm (%updaters): Add %cpan-updater.

[...]

> +(define core-module?
> +  (let ((perl-version (package-version perl))
> +        (rx (make-regexp
> +             (string-append "released with perl v?([0-9\\.]*)"
> +                            "(.*and removed from v?([0-9\\.]*))?"))))
> +    (lambda (name)

For clarity you could make this change (moving =E2=80=98core-module?=E2=80=
=99 to the top
level) in a separate patch maybe.

Otherwise that LGTM, though I haven=E2=80=99t actually tested it.

Thank you!

Ludo=E2=80=99.