Re: [PATCH 1/2] services: postgresql: Add port to configuration

[ludo@gnu.org (Ludovic Courtès)]

Hi!

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/services/postgresql.scm (<postgresql-configuration>): Add port
>   field.
>   (postgresql-shepherd-service): Pass port to postgres.
>   (postgresql-service): Add port default.

[...]

> --- a/gnu/services/databases.scm
> +++ b/gnu/services/databases.scm
> @@ -48,6 +48,8 @@
>    postgresql-configuration?
>    (postgresql     postgresql-configuration-postgresql ;<package>
>                    (default postgresql))
> +  (port           postgresql-configuration-port
> +                  (default 5432))

Could you update guix.texi to reflect these changes?

> +    (($ <postgresql-configuration> postgresql port config-file data-directory)
> +     (let* ((string-port (number->string port))
> +            (start-script
> +             ;; Wrapper script that switches to the 'postgres' user before
> +             ;; launching daemon.
> +             (program-file "start-postgres"
> +                           #~(let ((user (getpwnam "postgres"))
> +                                   (postgres (string-append #$postgresql
> +                                                            "/bin/postgres")))
> +                               (setgid (passwd:gid user))
> +                               (setuid (passwd:uid user))
> +                               (system* postgres
> +                                        (string-append "--config-file="
> +                                                       #$config-file)
> +                                        "-p" #$string-port

I think you can omit the ‘string-port’ variable (confusing name IMO :-))
and directly write:

  "-p" #$(number->string port)

Could you send an updated patch?

Thanks!

Ludo’.