From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] Add pagure SCM/forge Date: Mon, 12 Dec 2016 09:21:44 +0000 Message-ID: <87zik1jydz.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> References: <20161211181237.24485-1-ng0@libertad.pw> <20161211225204.GE9474@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGMoC-0007CH-5I for guix-devel@gnu.org; Mon, 12 Dec 2016 04:22:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGMo9-0001I6-1R for guix-devel@gnu.org; Mon, 12 Dec 2016 04:22:08 -0500 Received: from aibo.runbox.com ([91.220.196.211]:41158) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGMo8-0001Hr-Rj for guix-devel@gnu.org; Mon, 12 Dec 2016 04:22:04 -0500 Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1cGMo2-0002Q5-O3 for guix-devel@gnu.org; Mon, 12 Dec 2016 10:21:58 +0100 Received: from exit1.tor.outfall.net ([195.154.122.54] helo=localhost) by mailfront12.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1cGMnt-0006Bb-Mg for guix-devel@gnu.org; Mon, 12 Dec 2016 10:21:50 +0100 In-Reply-To: <20161211225204.GE9474@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Leo Famulari writes: > On Sun, Dec 11, 2016 at 06:12:26PM +0000, ng0 wrote: >> [PATCH 01/11] gnu: Add python-flask-wtf. >> [PATCH 02/11] gnu: Add python-flask-multistatic. >> [PATCH 03/11] gnu: Add python-kitchen. >> [PATCH 04/11] gnu: Add python-munch. >> [PATCH 05/11] gnu: Add python-pygit2. >> [PATCH 06/11] gnu: Add python2-openid. >> [PATCH 07/11] gnu: Add python-openid-cla. >> [PATCH 08/11] gnu: Add python-openid-teams. >> [PATCH 09/11] gnu: Add python-straight.plugin. >> [PATCH 10/11] gnu: Add python-trollius-redis. >> [PATCH 11/11] gnu: Add pagure. > > Awesome! > > I sent a few comments about licenses. Can you check those and send > updated patches if necessary? > > I also noticed a few packages that pull their source from GitHub even > though it is available on PyPi, like python-openid-teams: > > https://pypi.python.org/pypi/python-openid-teams > > Is there a reason for that? If not, can you make sure to use the PyPi > source code instead? > > Thanks! > Wasn't it like when the source is on github or somewhere else upstream, we should loose the dependency on pypi infrastructure and use that upstream? That's why I changed source where possible. I can send the updates when I'm back from Berlin, late Wednesday - Thursday'ish Thanks for your review. -- ♥Ⓐ ng0 | ng0.chaosnet.org