Re: [PATCH 01/12] upstream: Use a the first url from urls when find2 returns #f.

[ludo@gnu.org (Ludovic Courtès)]

David Craven <david@craven.ch> skribis:

> * guix/upstream.scm (package-update): Use a url from the list when the
>   find2 procedure doesn't find a url sig-url pair.
> ---
>  guix/upstream.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/upstream.scm b/guix/upstream.scm
> index 8685afd86..579942672 100644
> --- a/guix/upstream.scm
> +++ b/guix/upstream.scm
> @@ -249,7 +249,7 @@ and 'interactive' (default)."
>                               (string-suffix? archive-type url))
>                             urls
>                             (or signature-urls (circular-list #f)))))
> -       (let ((tarball (download-tarball store url signature-url
> +       (let ((tarball (download-tarball store (if url url (car urls)) signature-url

Please make it (or url (first urls)).

Could it be that commit 8d5d06282e255557d3bdda1794bd3fea2c84ff59 made it
moot?  What are the faulty values for ‘urls’ and ‘signature-urls’ that
trigger the problem?

Thanks, and sorry for taking long for just one line!

Ludo’.