unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH 1/2] gnu: Add r-bit.
@ 2016-12-13 10:00 Ben Woodcroft
  2016-12-13 10:00 ` [PATCH 2/2] gnu: Add r-bit64 Ben Woodcroft
  2016-12-13 16:30 ` [PATCH 1/2] gnu: Add r-bit Ricardo Wurmus
  0 siblings, 2 replies; 5+ messages in thread
From: Ben Woodcroft @ 2016-12-13 10:00 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/statistics.scm (r-bit): New variable.
---
 gnu/packages/statistics.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 36f1889ef..ea9ef0e39 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -205,6 +205,29 @@ publication-quality data plots.  A large amount of 3rd-party packages are
 available, greatly increasing its breadth and scope.")
     (license license:gpl3+)))
 
+(define-public r-bit
+  (package
+    (name "r-bit")
+    (version "1.1-12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "bit" version))
+       (sha256
+        (base32
+         "0a6ig6nnjzq80r2ll4hc74za3xwzbzig6wlyb4dby0knzf3iqa6f"))))
+    (build-system r-build-system)
+    (home-page "http://ff.r-forge.r-project.org")
+    (synopsis "A class for vectors of 1-bit booleans")
+    (description
+     "This package provides bitmapped vectors of booleans (no NAs), coercion
+from and to logicals, integers and integer subscripts; fast boolean operators
+and fast summary statistics.  With 'bit' vectors true binary booleans
+{FALSE,TRUE} can be stored with 1 bit only, on a 32 bit architecture this
+means factor of 32 less RAM and a factor of 32 more speed on boolean
+operations.")
+    (license license:gpl2)))
+
 (define-public r-colorspace
   (package
     (name "r-colorspace")
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] gnu: Add r-bit64.
  2016-12-13 10:00 [PATCH 1/2] gnu: Add r-bit Ben Woodcroft
@ 2016-12-13 10:00 ` Ben Woodcroft
  2016-12-13 16:33   ` Ricardo Wurmus
  2016-12-13 16:30 ` [PATCH 1/2] gnu: Add r-bit Ricardo Wurmus
  1 sibling, 1 reply; 5+ messages in thread
From: Ben Woodcroft @ 2016-12-13 10:00 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/statistics.scm (r-bit64): New variable.
---
 gnu/packages/statistics.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index ea9ef0e39..8af94e6af 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -228,6 +228,32 @@ means factor of 32 less RAM and a factor of 32 more speed on boolean
 operations.")
     (license license:gpl2)))
 
+(define-public r-bit64
+  (package
+    (name "r-bit64")
+    (version "0.9-5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "bit64" version))
+       (sha256
+        (base32
+         "0fz5m3fhvxgwjl76maag7yn0zdw24rx34gy6v77378fajag9yllg"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-bit" ,r-bit)))
+    (home-page "http://ff.r-forge.r-project.org/")
+    (synopsis "An S3 class for vectors of 64 bit Integers")
+    (description
+     "The bit64 package provides serializable S3 atomic 64 bit (signed)
+integers that can be used in vectors, matrices, arrays and data.frames.
+Methods are available for coercion from and to logicals, integers, doubles,
+characters and factors as well as many elementwise and summary functions.
+Many fast algorithmic operations such as 'match' and 'order' support
+interactive data exploration and manipulation and optionally leverage
+caching.")
+    (license license:gpl2)))
+
 (define-public r-colorspace
   (package
     (name "r-colorspace")
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] gnu: Add r-bit.
  2016-12-13 10:00 [PATCH 1/2] gnu: Add r-bit Ben Woodcroft
  2016-12-13 10:00 ` [PATCH 2/2] gnu: Add r-bit64 Ben Woodcroft
@ 2016-12-13 16:30 ` Ricardo Wurmus
  2016-12-14 10:45   ` Ben Woodcroft
  1 sibling, 1 reply; 5+ messages in thread
From: Ricardo Wurmus @ 2016-12-13 16:30 UTC (permalink / raw)
  To: Ben Woodcroft; +Cc: guix-devel


Hi Ben,

thanks for the patch!

> * gnu/packages/statistics.scm (r-bit): New variable.
> ---
>  gnu/packages/statistics.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index 36f1889ef..ea9ef0e39 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -205,6 +205,29 @@ publication-quality data plots.  A large amount of 3rd-party packages are
>  available, greatly increasing its breadth and scope.")
>      (license license:gpl3+)))
>  
> +(define-public r-bit
> +  (package
> +    (name "r-bit")
> +    (version "1.1-12")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "bit" version))
> +       (sha256
> +        (base32
> +         "0a6ig6nnjzq80r2ll4hc74za3xwzbzig6wlyb4dby0knzf3iqa6f"))))
> +    (build-system r-build-system)
> +    (home-page "http://ff.r-forge.r-project.org")
> +    (synopsis "A class for vectors of 1-bit booleans")

Without “A” please.  Just “Class for vectors …”.

> +    (description
> +     "This package provides bitmapped vectors of booleans (no NAs), coercion
> +from and to logicals, integers and integer subscripts; fast boolean operators
> +and fast summary statistics.  With 'bit' vectors true binary booleans

“With *the @code{bit} class* vectors *of* true binary booleans …”

> +{FALSE,TRUE} can be stored with 1 bit only, on a 32 bit architecture this
> +means factor of 32 less RAM and a factor of 32 more speed on boolean
> +operations.")

I’d leave off “, on a 32 bit architecure …”.  If you want to keep it,
though, I’d suggest making this a separate full sentence (or at least
separate them with a semicolon).

> +    (license license:gpl2)))
> +
>  (define-public r-colorspace
>    (package
>      (name "r-colorspace")

Pity it’s GPL2 only, but this seems to be correct (there are even
license headers with an explicit version).

Okay with these changes.  Thanks!

-- 
Ricardo
  
GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] gnu: Add r-bit64.
  2016-12-13 10:00 ` [PATCH 2/2] gnu: Add r-bit64 Ben Woodcroft
@ 2016-12-13 16:33   ` Ricardo Wurmus
  0 siblings, 0 replies; 5+ messages in thread
From: Ricardo Wurmus @ 2016-12-13 16:33 UTC (permalink / raw)
  To: Ben Woodcroft; +Cc: guix-devel


Hi Ben,

> * gnu/packages/statistics.scm (r-bit64): New variable.
> ---
>  gnu/packages/statistics.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
> index ea9ef0e39..8af94e6af 100644
> --- a/gnu/packages/statistics.scm
> +++ b/gnu/packages/statistics.scm
> @@ -228,6 +228,32 @@ means factor of 32 less RAM and a factor of 32 more speed on boolean
>  operations.")
>      (license license:gpl2)))
>  
> +(define-public r-bit64
> +  (package
> +    (name "r-bit64")
> +    (version "0.9-5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "bit64" version))
> +       (sha256
> +        (base32
> +         "0fz5m3fhvxgwjl76maag7yn0zdw24rx34gy6v77378fajag9yllg"))))
> +    (build-system r-build-system)
> +    (propagated-inputs
> +     `(("r-bit" ,r-bit)))
> +    (home-page "http://ff.r-forge.r-project.org/")
> +    (synopsis "An S3 class for vectors of 64 bit Integers")

s/An//

also “integers” (not “Integers”)

> +    (description
> +     "The bit64 package provides serializable S3 atomic 64 bit (signed)
> +integers that can be used in vectors, matrices, arrays and
> data.frames.

@code{data.frames} ?

> +Methods are available for coercion from and to logicals, integers, doubles,
> +characters and factors as well as many elementwise and summary functions.
> +Many fast algorithmic operations such as 'match' and 'order' support

@code{match} and @code{order}

> +interactive data exploration and manipulation and optionally leverage
> +caching.")
> +    (license license:gpl2)))
> +
>  (define-public r-colorspace
>    (package
>      (name "r-colorspace")

Thanks!

-- 
Ricardo
  
GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
http://elephly.net

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] gnu: Add r-bit.
  2016-12-13 16:30 ` [PATCH 1/2] gnu: Add r-bit Ricardo Wurmus
@ 2016-12-14 10:45   ` Ben Woodcroft
  0 siblings, 0 replies; 5+ messages in thread
From: Ben Woodcroft @ 2016-12-14 10:45 UTC (permalink / raw)
  To: Ricardo Wurmus, Ben Woodcroft; +Cc: guix-devel

On 14/12/16 02:30, Ricardo Wurmus wrote:
> [..]
>
> Okay with these changes.  Thanks!

Quite right. I made a few more changes to the description and push the 
series ending in 'ce3f92e7018e140f5e6b7333a604f26506de6c2a'.

Thanks for the prompt review.
ben

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-12-14 10:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-13 10:00 [PATCH 1/2] gnu: Add r-bit Ben Woodcroft
2016-12-13 10:00 ` [PATCH 2/2] gnu: Add r-bit64 Ben Woodcroft
2016-12-13 16:33   ` Ricardo Wurmus
2016-12-13 16:30 ` [PATCH 1/2] gnu: Add r-bit Ricardo Wurmus
2016-12-14 10:45   ` Ben Woodcroft

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).