unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH v2] gnu: Add ghc-markdown-unlit.
@ 2017-01-04 15:21 Danny Milosavljevic
  2017-01-05 14:00 ` Marius Bakke
  0 siblings, 1 reply; 4+ messages in thread
From: Danny Milosavljevic @ 2017-01-04 15:21 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/haskell.scm (ghc-markdown-unlit): New variable.
---
 gnu/packages/haskell.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index de061a630..1f6611d0b 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -8073,4 +8073,33 @@ It features a complete, well-tested parser and pretty printer for all of C99
 and a large set of GNU extensions.")
     (license license:bsd-3)))
 
+(define-public ghc-markdown-unlit
+  (package
+   (name "ghc-markdown-unlit")
+   (version "0.4.0")
+   (source (origin
+     (method url-fetch)
+     (uri (string-append
+            "https://hackage.haskell.org/package/markdown-unlit/"
+            "markdown-unlit-" version ".tar.gz"))
+     (sha256
+       (base32
+         "1kj2bffl7ndd8ygwwa3r1mbpwbxbfhyfgnbla8k8g9i6ffp0qrbw"))))
+   (build-system haskell-build-system)
+   (inputs
+    `(("ghc-base-compat" ,ghc-base-compat)
+      ("ghc-hspec" ,ghc-hspec)
+      ("ghc-quickcheck" ,ghc-quickcheck)
+      ("ghc-silently" ,ghc-silently)
+      ("ghc-stringbuilder" ,ghc-stringbuilder)
+      ("ghc-temporary" ,ghc-temporary)))
+   (native-inputs
+    `(("hspec-discover" ,hspec-discover)))
+   (home-page "https://github.com/sol/markdown-unlit#readme")
+   (synopsis "Literate Haskell support for Markdown")
+   (description "This package allows you to have a README.md that at the
+same time is a literate Haskell program.  See also $url{Documentation,
+https://github.com/sol/markdown-unlit#readme}.")
+   (license license:expat)))
+
 ;;; haskell.scm ends here

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] gnu: Add ghc-markdown-unlit.
  2017-01-04 15:21 [PATCH v2] gnu: Add ghc-markdown-unlit Danny Milosavljevic
@ 2017-01-05 14:00 ` Marius Bakke
  2017-01-05 15:50   ` [PATCH v3] " Danny Milosavljevic
  0 siblings, 1 reply; 4+ messages in thread
From: Marius Bakke @ 2017-01-05 14:00 UTC (permalink / raw)
  To: Danny Milosavljevic, guix-devel

[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/haskell.scm (ghc-markdown-unlit): New variable.
> ---
>  gnu/packages/haskell.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index de061a630..1f6611d0b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -8073,4 +8073,33 @@ It features a complete, well-tested parser and pretty printer for all of C99
>  and a large set of GNU extensions.")
>      (license license:bsd-3)))
>  
> +(define-public ghc-markdown-unlit
> +  (package
> +   (name "ghc-markdown-unlit")
> +   (version "0.4.0")
> +   (source (origin
> +     (method url-fetch)
> +     (uri (string-append
> +            "https://hackage.haskell.org/package/markdown-unlit/"
> +            "markdown-unlit-" version ".tar.gz"))
> +     (sha256
> +       (base32
> +         "1kj2bffl7ndd8ygwwa3r1mbpwbxbfhyfgnbla8k8g9i6ffp0qrbw"))))
> +   (build-system haskell-build-system)
> +   (inputs
> +    `(("ghc-base-compat" ,ghc-base-compat)
> +      ("ghc-hspec" ,ghc-hspec)
> +      ("ghc-quickcheck" ,ghc-quickcheck)
> +      ("ghc-silently" ,ghc-silently)
> +      ("ghc-stringbuilder" ,ghc-stringbuilder)
> +      ("ghc-temporary" ,ghc-temporary)))
> +   (native-inputs
> +    `(("hspec-discover" ,hspec-discover)))
> +   (home-page "https://github.com/sol/markdown-unlit#readme")
> +   (synopsis "Literate Haskell support for Markdown")
> +   (description "This package allows you to have a README.md that at the
> +same time is a literate Haskell program.  See also $url{Documentation,
> +https://github.com/sol/markdown-unlit#readme}.")

I don't think linking the home page in the description is necessary.
What do you think about removing the last sentence? Otherwise LGTM with
a few indentation changes that can be fixed before pushing ;-)

As a side note, do we have volunteers to make the hackage importer
return a "mirror://hackage" uri? IIRC this is needed for pypi too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3] gnu: Add ghc-markdown-unlit.
  2017-01-05 14:00 ` Marius Bakke
@ 2017-01-05 15:50   ` Danny Milosavljevic
  2017-01-05 18:00     ` Marius Bakke
  0 siblings, 1 reply; 4+ messages in thread
From: Danny Milosavljevic @ 2017-01-05 15:50 UTC (permalink / raw)
  To: guix-devel

* gnu/packages/haskell.scm (ghc-markdown-unlit): New variable.
---
 gnu/packages/haskell.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index de061a630..5d3c85475 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -8073,4 +8073,31 @@ It features a complete, well-tested parser and pretty printer for all of C99
 and a large set of GNU extensions.")
     (license license:bsd-3)))
 
+(define-public ghc-markdown-unlit
+  (package
+   (name "ghc-markdown-unlit")
+   (version "0.4.0")
+   (source (origin
+     (method url-fetch)
+     (uri (string-append "https://hackage.haskell.org/package/markdown-unlit/"
+                         "markdown-unlit-" version ".tar.gz"))
+     (sha256
+       (base32
+         "1kj2bffl7ndd8ygwwa3r1mbpwbxbfhyfgnbla8k8g9i6ffp0qrbw"))))
+   (build-system haskell-build-system)
+   (inputs
+    `(("ghc-base-compat" ,ghc-base-compat)
+      ("ghc-hspec" ,ghc-hspec)
+      ("ghc-quickcheck" ,ghc-quickcheck)
+      ("ghc-silently" ,ghc-silently)
+      ("ghc-stringbuilder" ,ghc-stringbuilder)
+      ("ghc-temporary" ,ghc-temporary)))
+   (native-inputs
+    `(("hspec-discover" ,hspec-discover)))
+   (home-page "https://github.com/sol/markdown-unlit#readme")
+   (synopsis "Literate Haskell support for Markdown")
+   (description "This package allows you to have a README.md that at the
+same time is a literate Haskell program.")
+   (license license:expat)))
+
 ;;; haskell.scm ends here

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] gnu: Add ghc-markdown-unlit.
  2017-01-05 15:50   ` [PATCH v3] " Danny Milosavljevic
@ 2017-01-05 18:00     ` Marius Bakke
  0 siblings, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2017-01-05 18:00 UTC (permalink / raw)
  To: Danny Milosavljevic, guix-devel

[-- Attachment #1: Type: text/plain, Size: 1654 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/haskell.scm (ghc-markdown-unlit): New variable.
> ---
>  gnu/packages/haskell.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index de061a630..5d3c85475 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -8073,4 +8073,31 @@ It features a complete, well-tested parser and pretty printer for all of C99
>  and a large set of GNU extensions.")
>      (license license:bsd-3)))
>  
> +(define-public ghc-markdown-unlit
> +  (package
> +   (name "ghc-markdown-unlit")
> +   (version "0.4.0")
> +   (source (origin
> +     (method url-fetch)
> +     (uri (string-append "https://hackage.haskell.org/package/markdown-unlit/"
> +                         "markdown-unlit-" version ".tar.gz"))
> +     (sha256
> +       (base32
> +         "1kj2bffl7ndd8ygwwa3r1mbpwbxbfhyfgnbla8k8g9i6ffp0qrbw"))))
> +   (build-system haskell-build-system)
> +   (inputs
> +    `(("ghc-base-compat" ,ghc-base-compat)
> +      ("ghc-hspec" ,ghc-hspec)
> +      ("ghc-quickcheck" ,ghc-quickcheck)
> +      ("ghc-silently" ,ghc-silently)
> +      ("ghc-stringbuilder" ,ghc-stringbuilder)
> +      ("ghc-temporary" ,ghc-temporary)))
> +   (native-inputs
> +    `(("hspec-discover" ,hspec-discover)))

I noticed this was referenced by the binary and library for some reason,
so I made hspec-discover a regular input. It would be good to figure out
why it's referenced as it doesn't seem like it should be needed.

Pushed with indentation fixes! :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-05 18:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-04 15:21 [PATCH v2] gnu: Add ghc-markdown-unlit Danny Milosavljevic
2017-01-05 14:00 ` Marius Bakke
2017-01-05 15:50   ` [PATCH v3] " Danny Milosavljevic
2017-01-05 18:00     ` Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).