[PATCH] gnu: Add emacs-ag

[PATCH] gnu: Add emacs-ag

[Christopher Baines]

* gnu/packages/emacs.scm (emacs-ag): New variable.
---
 gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 50cea7685..6933dcc35 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -46,6 +46,7 @@
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
+  #:use-module (gnu packages code)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages gnome)
@@ -1066,6 +1067,32 @@ like.  It can be linked with various Emacs mail clients (Message and Mail
 mode, Rmail, Gnus, MH-E, and VM).  BBDB is fully customizable.")
     (license license:gpl3+)))
 
+(define-public emacs-ag
+  (package
+    (name "emacs-ag")
+    (version "0.47")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "https://github.com/Wilfred/ag.el/archive/"
+                   version ".tar.gz"))
+             (file-name (string-append name "-" version ".tar.gz"))
+             (sha256
+              (base32
+               "1rlmp6wnyhqfg86dbz17r914msp58favn4kd4yrdwyia265a4lar"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("the-silver-searcher" ,the-silver-searcher)
+       ("dash" ,emacs-dash)
+       ("s" ,emacs-s)))
+    (home-page "https://github.com/Wilfred/ag.el")
+    (synopsis "Front-end for ag (the-silver-searcher) for Emacs")
+    (description "This package provides the ability to use the silver
+searcher, also called @code{ag}.  Features include version control system
+awareness, use of Perl compatible regular expressions, editing the search
+results directly and searching file names rather than the contents of files.")
+    (license license:gpl3+)))
+
 (define-public emacs-async
   (package
     (name "emacs-async")
-- 
2.11.0

Re: [PATCH] gnu: Add emacs-ag

[Hartmut Goebel]

Am 15.01.2017 um 12:25 schrieb Christopher Baines:
> the silver searcher

Please explain shortly what this is in the description.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH] gnu: Add emacs-ag

[ng0]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Am 15.01.2017 um 12:25 schrieb Christopher Baines:
>> the silver searcher
>
> Please explain shortly what this is in the description.
>

Why? In my opinion this is already explained when you do
"guix package -s the-silver-searcher", so the only added
explanation maybe should be a @code{the-silver-searcher}.

-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

Re: [PATCH] gnu: Add emacs-ag

[Hartmut Goebel]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Am 15.01.2017 um 17:13 schrieb ng0:
>> Am 15.01.2017 um 12:25 schrieb Christopher Baines:
>>> the silver searcher
>> Please explain shortly what this is in the description.
>>
> Why? In my opinion this is already explained when you do

As a service for those who do not know what "the solver searcher" is.
Adding "code searching tool" to the description should not be much of a
problem.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |


[-- Attachment #2: Type: text/html, Size: 1398 bytes --]

Re: [PATCH] gnu: Add emacs-ag

[ng0]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> Am 15.01.2017 um 17:13 schrieb ng0:
>>> Am 15.01.2017 um 12:25 schrieb Christopher Baines:
>>>> the silver searcher
>>> Please explain shortly what this is in the description.
>>>
>> Why? In my opinion this is already explained when you do
>
> As a service for those who do not know what "the solver searcher" is.
> Adding "code searching tool" to the description should not be much of a
> problem.

I've read it again and it might help when "a code searching tool"
is added.

> -- 
> Regards
> Hartmut Goebel
>
> | Hartmut Goebel          | h.goebel@crazy-compilers.com               |
> | www.crazy-compilers.com | compilers which you thought are impossible |
>

-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

Re: [PATCH] gnu: Add emacs-ag

[Alex Kost]

Christopher Baines (2017-01-15 11:25 +0000) wrote:

> * gnu/packages/emacs.scm (emacs-ag): New variable.
> ---
>  gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 50cea7685..6933dcc35 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -46,6 +46,7 @@
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system trivial)
>    #:use-module (gnu packages)
> +  #:use-module (gnu packages code)
>    #:use-module (gnu packages guile)
>    #:use-module (gnu packages gtk)
>    #:use-module (gnu packages gnome)
> @@ -1066,6 +1067,32 @@ like.  It can be linked with various Emacs mail clients (Message and Mail
>  mode, Rmail, Gnus, MH-E, and VM).  BBDB is fully customizable.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-ag
> +  (package
> +    (name "emacs-ag")
> +    (version "0.47")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "https://github.com/Wilfred/ag.el/archive/"
> +                   version ".tar.gz"))
> +             (file-name (string-append name "-" version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "1rlmp6wnyhqfg86dbz17r914msp58favn4kd4yrdwyia265a4lar"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("the-silver-searcher" ,the-silver-searcher)

Is it propagated just because "ag" executable is needed?  If so, then
it's better to keep it in 'inputs' and to change the value of
'ag-executable' variable (in "ag.el") using 'emacs-substitute-variables'.
See 'emacs-slime', 'emacs-w3m', etc. for examples.

> +       ("dash" ,emacs-dash)
> +       ("s" ,emacs-s)))
> +    (home-page "https://github.com/Wilfred/ag.el")
> +    (synopsis "Front-end for ag (the-silver-searcher) for Emacs")
> +    (description "This package provides the ability to use the silver
> +searcher, also called @code{ag}.  Features include version control system
> +awareness, use of Perl compatible regular expressions, editing the search
> +results directly and searching file names rather than the contents of files.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-async
>    (package
>      (name "emacs-async")

-- 
Alex

[PATCH] gnu: Add emacs-ag

[Christopher Baines]

* gnu/packages/emacs.scm (emacs-ag): New variable.
---
 gnu/packages/emacs.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 50cea7685..62b8dcc46 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -46,6 +46,7 @@
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
+  #:use-module (gnu packages code)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages gnome)
@@ -1066,6 +1067,43 @@ like.  It can be linked with various Emacs mail clients (Message and Mail
 mode, Rmail, Gnus, MH-E, and VM).  BBDB is fully customizable.")
     (license license:gpl3+)))
 
+(define-public emacs-ag
+  (package
+    (name "emacs-ag")
+    (version "0.47")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "https://github.com/Wilfred/ag.el/archive/"
+                   version ".tar.gz"))
+             (file-name (string-append name "-" version ".tar.gz"))
+             (sha256
+              (base32
+               "1rlmp6wnyhqfg86dbz17r914msp58favn4kd4yrdwyia265a4lar"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'configure
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (emacs-substitute-variables "ag.el"
+                         ("ag-executable" (string-append
+                                           (assoc-ref inputs "the-silver-searcher")
+                                           "/bin/ag")))
+                       #t)))))
+    (propagated-inputs
+     `(("the-silver-searcher" ,the-silver-searcher)
+       ("dash" ,emacs-dash)
+       ("s" ,emacs-s)))
+    (home-page "https://github.com/Wilfred/ag.el")
+    (synopsis "Front-end for ag (the-silver-searcher) for Emacs")
+    (description "This package provides the ability to use the silver
+searcher, a code searching tool, sometimes abbreviated to @code{ag}.  Features
+include version control system awareness, use of Perl compatible regular
+expressions, editing the search results directly and searching file names
+rather than the contents of files.")
+    (license license:gpl3+)))
+
 (define-public emacs-async
   (package
     (name "emacs-async")
-- 
2.11.0

[PATCH] gnu: Add emacs-ag

[Christopher Baines]

* gnu/packages/emacs.scm (emacs-ag): New variable.
---
 gnu/packages/emacs.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 50cea7685..45337097b 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -46,6 +46,7 @@
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
+  #:use-module (gnu packages code)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages gnome)
@@ -1066,6 +1067,44 @@ like.  It can be linked with various Emacs mail clients (Message and Mail
 mode, Rmail, Gnus, MH-E, and VM).  BBDB is fully customizable.")
     (license license:gpl3+)))
 
+(define-public emacs-ag
+  (package
+    (name "emacs-ag")
+    (version "0.47")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "https://github.com/Wilfred/ag.el/archive/"
+                   version ".tar.gz"))
+             (file-name (string-append name "-" version ".tar.gz"))
+             (sha256
+              (base32
+               "1rlmp6wnyhqfg86dbz17r914msp58favn4kd4yrdwyia265a4lar"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'configure
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (emacs-substitute-variables "ag.el"
+                         ("ag-executable" (string-append
+                                           (assoc-ref inputs "the-silver-searcher")
+                                           "/bin/ag")))
+                       #t)))))
+    (inputs
+     `(("the-silver-searcher" ,the-silver-searcher)))
+    (propagated-inputs
+     `(("dash" ,emacs-dash)
+       ("s" ,emacs-s)))
+    (home-page "https://github.com/Wilfred/ag.el")
+    (synopsis "Front-end for ag (the-silver-searcher) for Emacs")
+    (description "This package provides the ability to use the silver
+searcher, a code searching tool, sometimes abbreviated to @code{ag}.  Features
+include version control system awareness, use of Perl compatible regular
+expressions, editing the search results directly and searching file names
+rather than the contents of files.")
+    (license license:gpl3+)))
+
 (define-public emacs-async
   (package
     (name "emacs-async")
-- 
2.11.0

Re: [PATCH] gnu: Add emacs-ag

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

ng0 <ng0@libertad.pw> writes:

> Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
>
>> Am 15.01.2017 um 17:13 schrieb ng0:
>>>> Am 15.01.2017 um 12:25 schrieb Christopher Baines:
>>>>> the silver searcher
>>>> Please explain shortly what this is in the description.
>>>>
>>> Why? In my opinion this is already explained when you do
>>
>> As a service for those who do not know what "the solver searcher" is.
>> Adding "code searching tool" to the description should not be much of a
>> problem.
>
> I've read it again and it might help when "a code searching tool"
> is added.

I've added this to the description now and sent another patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: [PATCH] gnu: Add emacs-ag

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 1981 bytes --]

Alex Kost <alezost@gmail.com> writes:

> Christopher Baines (2017-01-15 11:25 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-ag): New variable.
>> ---
>>  gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 50cea7685..6933dcc35 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -46,6 +46,7 @@
>>    #:use-module (guix build-system glib-or-gtk)
>>    #:use-module (guix build-system trivial)
>>    #:use-module (gnu packages)
>> +  #:use-module (gnu packages code)
>>    #:use-module (gnu packages guile)
>>    #:use-module (gnu packages gtk)
>>    #:use-module (gnu packages gnome)
>> @@ -1066,6 +1067,32 @@ like.  It can be linked with various Emacs mail clients (Message and Mail
>>  mode, Rmail, Gnus, MH-E, and VM).  BBDB is fully customizable.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-ag
>> +  (package
>> +    (name "emacs-ag")
>> +    (version "0.47")
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                   "https://github.com/Wilfred/ag.el/archive/"
>> +                   version ".tar.gz"))
>> +             (file-name (string-append name "-" version ".tar.gz"))
>> +             (sha256
>> +              (base32
>> +               "1rlmp6wnyhqfg86dbz17r914msp58favn4kd4yrdwyia265a4lar"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs
>> +     `(("the-silver-searcher" ,the-silver-searcher)
>
> Is it propagated just because "ag" executable is needed?  If so, then
> it's better to keep it in 'inputs' and to change the value of
> 'ag-executable' variable (in "ag.el") using 'emacs-substitute-variables'.
> See 'emacs-slime', 'emacs-w3m', etc. for examples.

Ah, cool, I didn't know doing this was so easy before :) I've sent
another patch with this change.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: [PATCH] gnu: Add emacs-ag

[Alex Kost]

Christopher Baines (2017-01-17 20:08 +0000) wrote:

> ng0 <ng0@libertad.pw> writes:
>
>> Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
>>
>>> Am 15.01.2017 um 17:13 schrieb ng0:
>>>>> Am 15.01.2017 um 12:25 schrieb Christopher Baines:
>>>>>> the silver searcher
>>>>> Please explain shortly what this is in the description.
>>>>>
>>>> Why? In my opinion this is already explained when you do
>>>
>>> As a service for those who do not know what "the solver searcher" is.
>>> Adding "code searching tool" to the description should not be much of a
>>> problem.
>>
>> I've read it again and it might help when "a code searching tool"
>> is added.
>
> I've added this to the description now and sent another patch.

Thanks!  I added a copyright line for you, adjusted indentation, renamed
'configure' phase to 'patch-exec-paths' (since this name is used for
similar phases in 'magit', 'emacs-w3m' and 'emacs-wget'), and committed
as cf006d2:

http://git.savannah.gnu.org/cgit/guix.git/commit/?id=cf006d2e738f473e7fb630b566e04c4872fa204b

-- 
Alex