Re: [PATCH] gnu: Add emacs-sx.

[ng0 <contact.ng0@cryptolab.net>]

Alex Kost <alezost@gmail.com> writes:

> ng0 (2017-01-15 21:10 +0000) wrote:
>
>> From: ng0 <ng0@we.make.ritual.n0.is>
>>
>> * gnu/packages/emacs.scm (emacs-sx): New variable.
>
> Thanks, I committed it as 899bcad310.  See the comments below.
>
>> ---
>>  gnu/packages/emacs.scm | 26 +++++++++++++++++++++++++-
>>  1 file changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 50cea7685..ca038bcb2 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -12,7 +12,7 @@
>>  ;;; Copyright © 2016 David Thompson <davet@gnu.org>
>>  ;;; Copyright © 2016 Matthew Jordan <matthewjordandevops@yandex.com>
>>  ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
>> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
>> +;;; Copyright © 2016, 2017 ng0 <contact.ng0@cryptolab.net>
>
> So are you going to use this email now?  ".mailmap" still prefers
> <ng0@libertad.pw>.

I am slowly fading out the use of my own domains as I see no
point in paying money for names. Yesterday I have switched all
the gnu.org lists to this email. The commits still happen with
the @libertad.pw adress, I see the copyright lines as contact
information. Some people I know don't use email addresses for
commits for example.
I will update the .mailmap later this year, at the point where I
make my commits with this email address.
Older commits I am working on for some time now still carry
various other emails, like the one you commited with emacs-sx.

>>  ;;; Copyright © 2016 Alex Griffin <a@ajgrf.com>
>>  ;;; Copyright © 2016 Nicolas Goaziou <mail@nicolasgoaziou.fr>
>>  ;;; Copyright © 2016 Alex Vong <alexvong1995@gmail.com>
>> @@ -1391,6 +1391,30 @@ allows easily move between them.")
>>  strings.")
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-sx
>> +  (package
>> +    (name "emacs-sx")
>> +    (version "0.4")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "https://github.com/vermiculus/sx.el/"
>> +                           "archive/v" version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar"))
>                                                      ^^^^^
> I changed it to ".tar.gz"

Oh, thanks. I forgot that one.

>> +       (sha256
>> +        (base32
>> +         "1w0xghfljqg31axcnv8gzlrd8pw25nji6idnrhflq0af9qh1dw03"))))
>> +    (build-system emacs-build-system)
>> +    (inputs
>> +     `(("emacs-markdown-mode" ,emacs-markdown-mode)
>> +       ("let-alist" ,let-alist)))
>
> All emacs dependencies should be propagated, otherwise the package will
> not work.

Okay, I did not know that. Does the importer know about this?

>> +    (home-page "https://github.com/vermiculus/sx.el/")
>> +    (synopsis "Emacs StackExchange client")
>> +    (description
>> +     "Emacs StackExchange client.  Ask and answer questions on
>> +Stack Overflow, Super User, and other StackExchange sites.")
>> +    (license license:gpl3+)))
>> +
>>  (define-public emacs-f
>>    (package
>>      (name "emacs-f")
>
> Also for those who may wonder, there are a lot of errors like this:
>
>   sx-method.el:33:1:Error: Creating directory: No such file or directory, /homeless-shelter/.emacs.d/.sx
>
> This leads to many uncompiled elisp files.  This issue is fixed in
> master so it should be OK in the next release:
>
> https://github.com/vermiculus/sx.el/commit/53816e1885df22391ecc820297c1fe7cd381a630

Did this occur when using the application? For me it worked, but
I have no StackExchange account, so I just searched and read a
bit, and no errors occured.

-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/