From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] import: github: Catch HTTP 403 error during fetch.
Date: Thu, 19 Jan 2017 17:19:13 +0100
Message-ID: <87ziinuiny.fsf@gnu.org>
References: <20170117081730.17927-1-m.othacehe@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52923)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cUFQl-0000j3-TO
	for guix-devel@gnu.org; Thu, 19 Jan 2017 11:19:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cUFQi-000425-NM
	for guix-devel@gnu.org; Thu, 19 Jan 2017 11:19:19 -0500
In-Reply-To: <20170117081730.17927-1-m.othacehe@gmail.com> (Mathieu OTHACEHE's
	message of "Tue, 17 Jan 2017 09:17:30 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu OTHACEHE <m.othacehe@gmail.com>
Cc: guix-devel@gnu.org

Mathieu OTHACEHE <m.othacehe@gmail.com> skribis:

> * guix/import/github.scm (json-fetch*): Catch 403 HTTP error that may be
>   raised if a github token has not been set.
>
> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>
> ---
>
> Hi,
>
> If too many github requests are made during a guix refresh (> 60/h),
> github will reject all further requests with a 403 error.
>
> The 403 error is not catch in json-fetch* guard, so guix refresh
> will exit at that point. The user never gets to error message
> informing that setting a GUIX_GITHUB_TOKEN may fix the problem.

Looks like the right to do indeed.  Applied, thanks!

Ludo=E2=80=99.