From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: 02/02: gnu: Add s. Date: Tue, 06 Jun 2017 20:58:50 +0300 Message-ID: <87zidl9ew5.fsf@gmail.com> References: <20170604144555.7655.18380@vcs0.savannah.gnu.org> <20170604144556.5AFA1206F7@vcs0.savannah.gnu.org> <878tl770ht.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIIkn-0004gh-ME for guix-devel@gnu.org; Tue, 06 Jun 2017 13:58:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIIkk-0006oE-Je for guix-devel@gnu.org; Tue, 06 Jun 2017 13:58:53 -0400 Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:33546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dIIkk-0006o0-Ct for guix-devel@gnu.org; Tue, 06 Jun 2017 13:58:50 -0400 Received: by mail-lf0-x229.google.com with SMTP id a136so75003104lfa.0 for ; Tue, 06 Jun 2017 10:58:50 -0700 (PDT) In-Reply-To: <878tl770ht.fsf@netris.org> (Mark H. Weaver's message of "Sun, 04 Jun 2017 20:15:58 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org Mark H Weaver (2017-06-04 20:15 -0400) wrote: >> +(define-public s >> + (let ((commit "6604341edb3a775ff94415762af3ee9bd86bfb3c") >> + (revision "1")) >> + (package >> + (name "s") >> + (version (string-append "0.0.0-" revision "." (string-take commit= 7))) > > I think we should rename this package and variable name to 's-shell' or > something along those lines. 's' is commonly used as a local variable > name. Single character variable names are in short supply, and I don't > think we should allocate them to packages. > > Thoughts? And what about "r" package? In my opinion, package names for "r" and "s" should stay the same =E2=80=93= I think these names are expected by users. As for the variable names, they may be renamed, if it is needed. --=20 Alex