unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: 02/02: gnu: Add s.
Date: Tue, 06 Jun 2017 20:58:50 +0300	[thread overview]
Message-ID: <87zidl9ew5.fsf@gmail.com> (raw)
In-Reply-To: <878tl770ht.fsf@netris.org> (Mark H. Weaver's message of "Sun, 04 Jun 2017 20:15:58 -0400")

Mark H Weaver (2017-06-04 20:15 -0400) wrote:

>> +(define-public s
>> +  (let ((commit "6604341edb3a775ff94415762af3ee9bd86bfb3c")
>> +        (revision "1"))
>> +    (package
>> +      (name "s")
>> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
>
> I think we should rename this package and variable name to 's-shell' or
> something along those lines.  's' is commonly used as a local variable
> name.  Single character variable names are in short supply, and I don't
> think we should allocate them to packages.
>
> Thoughts?

And what about "r" package?

In my opinion, package names for "r" and "s" should stay the same – I
think these names are expected by users.  As for the variable names,
they may be renamed, if it is needed.

-- 
Alex

  parent reply	other threads:[~2017-06-06 17:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170604144555.7655.18380@vcs0.savannah.gnu.org>
     [not found] ` <20170604144556.5AFA1206F7@vcs0.savannah.gnu.org>
2017-06-05  0:15   ` 02/02: gnu: Add s Mark H Weaver
2017-06-05  8:42     ` ng0
2017-06-05 15:44       ` Kei Kebreau
2017-06-06 17:58     ` Alex Kost [this message]
2017-06-06 20:47       ` Mark H Weaver
2017-06-07  9:29         ` Alex Kost
2017-06-07 22:25           ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zidl9ew5.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).