From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 03/07: gnu: libfive: Add snippet,
	enable tests and remove obsolete phase.
Date: Thu, 19 Apr 2018 17:19:48 +0200
Message-ID: <87zi1zi5pn.fsf@gnu.org>
References: <20180419095903.21090.36781@vcs0.savannah.gnu.org>
	<20180419095904.D9E2D204EE@vcs0.savannah.gnu.org>
	<87in8nidqp.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1f9BLk-0008LW-Tq
	for guix-devel@gnu.org; Thu, 19 Apr 2018 11:19:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1f9BLj-0006vP-Sh
	for guix-devel@gnu.org; Thu, 19 Apr 2018 11:19:52 -0400
Received: from hera.aquilenet.fr ([2a0c:e300::1]:54388)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <ludo@gnu.org>) id 1f9BLj-0006ul-Ls
	for guix-devel@gnu.org; Thu, 19 Apr 2018 11:19:51 -0400
In-Reply-To: <87in8nidqp.fsf@netris.org> (Mark H. Weaver's message of "Thu, 19
	Apr 2018 08:26:22 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit 0818c01aefbaa7ecce5e310ec5f70886850a7f9c
>> Author: Diego Nicola Barbato <dnbarbato@posteo.de>
>> Date:   Fri Apr 6 13:43:54 2018 +0200
>>
>>     gnu: libfive: Add snippet, enable tests and remove obsolete phase.
>>=20=20=20=20=20
>>     * gnu/packages/engineering.scm (libfive)[source]: Add snippet to
>>     remove bundled catch.
>
> [...]
>
>> +                (snippet
>> +                 ;; Remove bundled catch since we provide our own.
>> +                 '(delete-file "libfive/test/catch.hpp"))))
>
> It would be good to try to avoid adding more phases or snippets that
> return unspecified values.  I fixed every snippet in 'core-updates', but
> I guess more passes will be needed as these errors continue to be
> introduced.

Right, apologies for that; I=E2=80=99ve fixed this particular instance.

I look forward to the day where we can ignore those return values and
assume an exception is thrown when something goes wrong.  Thankfully the
work you=E2=80=99ve been doing on =E2=80=98core-updates=E2=80=99 should hel=
p us get there!

Ludo=E2=80=99.