From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: Fwd: Re: Patch file for colorize module
Date: Wed, 13 Jun 2018 00:12:45 +0200
Message-ID: <87zhzzbqn6.fsf@elephly.net>
References: <8ea5d026-fab9-7b12-198e-610ad7743cb2@swecha.net>
	<87zi0a3m3t.fsf@elephly.net>
	<07c93c07-2172-6bf1-6188-88830c1d8b4c@swecha.net>
	<87o9gpyq4t.fsf@elephly.net>
	<91773c8b-3072-2a82-dca3-cbeb5adf826d@swecha.net>
	<87fu1zznl3.fsf@elephly.net>
	<f76f5ced-df02-fdcd-0a7a-37565d5d8605@swecha.net>
	<87bmcnzjsp.fsf@elephly.net>
	<18408eca-ad0b-111a-0ef6-ab452c9ca89c@swecha.net>
	<878t7ryxvf.fsf@elephly.net>
	<02e1a59a-ebc1-dfce-e1d6-22e97e742214@swecha.net>
	<874lifypeb.fsf@elephly.net>
	<648f81fc-0607-2c3b-f9a3-ca3b29cd637b@swecha.net>
	<87bmck22uz.fsf@elephly.net>
	<c2401637-c975-d416-e3a2-7b1535924c61@swecha.net>
	<8736xv1xvq.fsf@elephly.net>
	<64dfaf0c-3bcf-7b76-5831-b1c41d3f5563@swecha.net>
	<CAE4v=pjiR2fVN3SoA+NqSt4T9VEvM9Gfsz9OUPW=7X9RnNE7mg@mail.gmail.com>
	<c1a084e9-b888-1d01-b1fe-3e423169e750@swecha.net>
	<877en4ccut.fsf@elephly.net>
	<2b03fcec-c2d8-0604-156c-70fe7643a6cb@swecha.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1fSrY2-0006YI-WB
	for guix-devel@gnu.org; Tue, 12 Jun 2018 18:13:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1fSrY0-0004nh-MG
	for guix-devel@gnu.org; Tue, 12 Jun 2018 18:13:54 -0400
Received: from sender-of-o51.zoho.com ([135.84.80.216]:21084)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <rekado@elephly.net>) id 1fSrY0-0004nK-FK
	for guix-devel@gnu.org; Tue, 12 Jun 2018 18:13:52 -0400
In-reply-to: <2b03fcec-c2d8-0604-156c-70fe7643a6cb@swecha.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Sahithi <sahi@swecha.net>
Cc: guix-devel <guix-devel@gnu.org>


Hi Sahithi,

thank you for rebasing it.

I have applied it successfully and I tested the output with this
command:

    ./pre-inst-env guix build --no-grafts --check hello

When I run this in the source directory I do see colours and extra dots
on every new line, and I see a couple of missing space characters, just
as your code specifies it.

Do you see this too? (If not, can you tell us what terminal you are
using?) At the very least you should see that every line starts with a
dot.

The next steps are to fix the errors in the regular expressions that
swallow certain space characters and to re-read the documentation of
=E2=80=9Cmake-soft-port=E2=80=9D to make sure that the procedures in the ve=
ctor behave
as they should.

--
Ricardo