unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Gábor Boskovits" <boskovits@gmail.com>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: Java bootstrap cleanups
Date: Tue, 11 Sep 2018 15:31:35 +0200	[thread overview]
Message-ID: <87zhwojh3c.fsf@elephly.net> (raw)
In-Reply-To: <CAE4v=piQL=46-61Yf+fyGR6HW7wqdQY3aRwCEoZh=QMYLjNLtQ@mail.gmail.com>


Hi Gábor,

> I have a few questions/suggestions but I would like to get some feedback
> before implementing them. This changeset would rebuild all java, so it
> would be nice to get this right for the first time.
>
> 1. https://issues.guix.info/issue/30730 has a partial fix, icedtea-8 out
> output is fixed. The same fix could be attempted at icedtea-7, and then we
> could inherit it.
> Also we could get rid of the repeated code in ant-bootstrap and co.
> 'strip-jar-timestamps the same way Ricardo did this in icedtea-8.

Yes, this seems like a good idea.

> 2. ISTM that https://issues.guix.info/issue/31719 is caused by not running
> strip on the jre directory. I don't know how widespread this kind of issue
> is throughout the codebase. If it is, then we might need to come up with a
> more generic solution, but in the meanwhile I would simply add a
> 'strip-jre-directory phase, or something like that. I guess that should
> interact with #: strip-binaries though.

Do you mean that the shared binaries that end up in the JRE directory
are not stripped and that stripping them gets rid of all these
references?  (You could test this by copying the binaries from the store
and stripping them manually.)

The icedtea packages use the gnu-build-system, so I would expect them to
be stripped by default.

> 3. some javadoc reproducibility issues could be mitigated by tweaking ant
> build system to pass -notimestamp to javadoc.
> WDYT?

Sounds good to me.

Thanks for working on this, Gábor!

--
Ricardo

      parent reply	other threads:[~2018-09-11 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11  7:32 Java bootstrap cleanups Gábor Boskovits
2018-09-11  8:40 ` Julien Lepiller
2018-09-11 13:31 ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhwojh3c.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=boskovits@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).