From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 01/01: gnu: Use make-linux-libre-headers.
Date: Wed, 29 May 2019 21:31:45 -0400
Message-ID: <87zhn4pw0z.fsf@netris.org>
References: <20190529163123.3417.15650@vcs0.savannah.gnu.org>
	<20190529163123.ECCE2209A5@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:48893)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1hW9wy-00050e-FE
	for guix-devel@gnu.org; Wed, 29 May 2019 21:33:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1hW9ww-0004bu-Hr
	for guix-devel@gnu.org; Wed, 29 May 2019 21:33:47 -0400
Received: from world.peace.net ([64.112.178.59]:45776)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mhw@netris.org>) id 1hW9ww-0004bZ-Eo
	for guix-devel@gnu.org; Wed, 29 May 2019 21:33:46 -0400
In-Reply-To: <20190529163123.ECCE2209A5@vcs0.savannah.gnu.org>
	(guix-commits@gnu.org's message of "Wed, 29 May 2019 12:31:23 -0400
	(EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Carl Dong <accounts@carldong.me>, guix-devel@gnu.org

Hi Danny and Carl,

guix-commits@gnu.org writes:

> dannym pushed a commit to branch master
> in repository guix.
>
> commit a15cee50cebddc665a16b455f44e22dcfb87d57f
> Author: Carl Dong <accounts@carldong.me>
> Date:   Wed May 29 18:04:43 2019 +0200
>
>     gnu: Use make-linux-libre-headers.
>     
>     * gnu/packages/linux.scm (make-linux-libre-headers): New variable.
>     (linux-libre): Rename to...
>     (linux-libre-5.1): ...this.
>     (linux-libre-headers): Rename to...
>     (linux-libre-headers-4.14.67): ...this.
>     (linux-libre-5.1, linux-libre-headers-4.14.67): Use make-linux-libre-headers.
>     (linux-libre-5.1, linux-libre-headers-5.1, linux-libre-headers-4.19,
>     %linux-libre-4.15-version, %linux-libre-4.15-hash, linux-libre-4.15,
>     linux-libre-headers-4.15, linux-libre-headers-4.14): New variables.
>     
>     Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>

I think we should not add linux-libre-4.15, because that version of
Linux-libre is no longer supported upstream, and therefore will have
well-known security flaws.

Also, this removes the definition of 'linux-libre', which I, for one,
reference from my OS config and maybe others do as well.  Sometimes it's
useful to break compatibility, but in this case I see no reason for it.

Finally, given I've been the de-facto maintainer of our kernel packages
since the early days of Guix, I would have appreciated a heads-up on
these proposed changes and an opportunity to comment before they were
pushed to master.

     Regards,
       Mark