From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IIwFNYip4F6ZFwAA0tVLHw (envelope-from ) for ; Wed, 10 Jun 2020 09:36:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id yEu7MIip4F7vPQAAbx9fmQ (envelope-from ) for ; Wed, 10 Jun 2020 09:36:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5AEE89408BB for ; Wed, 10 Jun 2020 09:36:08 +0000 (UTC) Received: from localhost ([::1]:59232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jix9T-0001sG-Cn for larch@yhetil.org; Wed, 10 Jun 2020 05:36:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jix9I-0001s6-H7 for guix-devel@gnu.org; Wed, 10 Jun 2020 05:35:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37667) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jix9H-0000WA-7I; Wed, 10 Jun 2020 05:35:55 -0400 Received: from lfbn-ann-1-136-86.w86-200.abo.wanadoo.fr ([86.200.104.86]:45200 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jix9F-0001Mw-Qj; Wed, 10 Jun 2020 05:35:55 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: Canonical-packages restoration. References: <87zh9co7xq.fsf@gnu.org> <875zc0gpuf.fsf@gnu.org> Date: Wed, 10 Jun 2020 11:35:49 +0200 In-Reply-To: <875zc0gpuf.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 09 Jun 2020 18:34:48 +0200") Message-ID: <87zh9bmfey.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 7V9X73rlcYQA --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hey Ludo! > What if, instead, we removed those =E2=80=9Ccanonical=E2=80=9D packages e= ntirely from > the reference graph? Do you think that=E2=80=99s an option? It seems to be a better option! So, as I did remove most of the explicit references to 'canonical-packages' the only references left are implicit. A good example is "isc-dhcp", that refers to implicit canonical inputs "coreutils" and "sed" in the "dhclient-script". The attached patch fixes it. I could do the same for a few other packages and it should fix the issue. The problem is that approach is not very long-term. Maybe we should take a step back. Would it be an option to add all the canonical-packages as disallowed-references? Or could we use implicit inputs that are not rooted in the bootstrap chain? >> My idea is to define something like: >> >> (define (canonical-package* package) >> (let ((canonical >> (module-ref (resolve-interface '(gnu packages base)) >> 'canonical-package))) >> (let-system (system target) >> (if target >> package >> (canonical package))))) > > Aren=E2=80=99t there pieces of code that expect these things to be > records? Yes, but I was planning to change that, not a good idea after all. > Bah yes, that=E2=80=99s why initially I didn=E2=80=99t push =E2=80=98let-= system=E2=80=99: > > https://issues.guix.gnu.org/29296#4 > > Perhaps we could avoid the expander =3D #f special case. Ok, I will try to fix it then. Thanks, Mathieu --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=patch Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9hZG1pbi5zY20gYi9nbnUvcGFja2FnZXMvYWRtaW4u c2NtCmluZGV4IDc3OTgxZTUyMGEuLjUzN2IxNjJiYTggMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdl cy9hZG1pbi5zY20KKysrIGIvZ251L3BhY2thZ2VzL2FkbWluLnNjbQpAQCAtMTAwNCwxMCArMTAw NCwxMCBAQCBjb25uZWN0aW9uIGFsaXZlLiIpCiAgICAgICAgICAgICAgICA7OyBpZiBmaW5kcyBh bGwgdGhlIHByb2dyYW1zIGl0IG5lZWRzLgogICAgICAgICAgICAgICAgKGxldCogKChvdXQgICAg ICAgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkKICAgICAgICAgICAgICAgICAgICAgICAobGli ZXhlYyAgIChzdHJpbmctYXBwZW5kIG91dCAiL2xpYmV4ZWMiKSkKLSAgICAgICAgICAgICAgICAg ICAgICAoY29yZXV0aWxzIChhc3NvYy1yZWYgaW5wdXRzICJjb3JldXRpbHMiKSkKKyAgICAgICAg ICAgICAgICAgICAgICAoY29yZXV0aWxzIChhc3NvYy1yZWYgaW5wdXRzICJjb3JldXRpbHMqIikp CiAgICAgICAgICAgICAgICAgICAgICAgKGluZXR1dGlscyAoYXNzb2MtcmVmIGlucHV0cyAiaW5l dHV0aWxzIikpCiAgICAgICAgICAgICAgICAgICAgICAgKG5ldC10b29scyAoYXNzb2MtcmVmIGlu cHV0cyAibmV0LXRvb2xzIikpCi0gICAgICAgICAgICAgICAgICAgICAgKHNlZCAgICAgICAoYXNz b2MtcmVmIGlucHV0cyAic2VkIikpKQorICAgICAgICAgICAgICAgICAgICAgIChzZWQgICAgICAg KGFzc29jLXJlZiBpbnB1dHMgInNlZCoiKSkpCiAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRl KiAiY2xpZW50L3NjcmlwdHMvbGludXgiCiAgICAgICAgICAgICAgICAgICAgKCgiL3NiaW4vaXAi KQogICAgICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVuZCAoYXNzb2MtcmVmIGlucHV0cyAi aXByb3V0ZSIpCkBAIC0xMDQ3LDEyICsxMDQ3LDggQEAgY29ubmVjdGlvbiBhbGl2ZS4iKQogICAg ICAgICAgICAgICAgICAgICAgKGJhc2UzMgogICAgICAgICAgICAgICAgICAgICAgICIwdndzMHp6 YjM5bWtwaGo0aGhqcmdmajlkenc5NTFsYzRwZmE2cHFnNWxsNW1hNTFtYnNyIikpKSkKIAotICAg ICAgICAgICAgICAgIDs7IFdoZW4gY3Jvc3MtY29tcGlsaW5nLCB3ZSBuZWVkIHRoZSBjcm9zcyBD b3JldXRpbHMgYW5kIHNlZC4KLSAgICAgICAgICAgICAgICA7OyBPdGhlcndpc2UganVzdCB1c2Ug dGhvc2UgZnJvbSAlRklOQUwtSU5QVVRTLgotICAgICAgICAgICAgICAgICxAKGlmICglY3VycmVu dC10YXJnZXQtc3lzdGVtKQotICAgICAgICAgICAgICAgICAgICAgIGAoKCJjb3JldXRpbHMiICxj b3JldXRpbHMpCi0gICAgICAgICAgICAgICAgICAgICAgICAoInNlZCIgLHNlZCkpCi0gICAgICAg ICAgICAgICAgICAgICAgJygpKSkpCisgICAgICAgICAgICAgICAgKCJjb3JldXRpbHMqIiAsY29y ZXV0aWxzKQorICAgICAgICAgICAgICAgICgic2VkKiIgLHNlZCkpKQogCiAgICAgICAoaG9tZS1w YWdlICJodHRwczovL3d3dy5pc2Mub3JnL3Byb2R1Y3RzL0RIQ1AvIikKICAgICAgIChzeW5vcHNp cyAiRHluYW1pYyBIb3N0IENvbmZpZ3VyYXRpb24gUHJvdG9jb2wgKERIQ1ApIHRvb2xzIikK --=-=-=--