unofficial mirror of guix-devel@gnu.org 
 help / color / Atom feed
* Jami bug source investigation #4
@ 2020-06-18  0:35 Jan Wielkiewicz
  2020-06-18  6:52 ` Pierre Neidhardt
  0 siblings, 1 reply; 12+ messages in thread
From: Jan Wielkiewicz @ 2020-06-18  0:35 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 3157 bytes --]

Hello,

I'm back trying to fetch Jami from git to check why is this strange,
irreproducible outside of Guix bug.
I managed to fetch libringclient (library for building clients) and
libring (the daemon) from git, but jami (Jami client for gnome) fails
during 'make' and I don't know why. The dependencies seem to be fine,
the version is the same as from the release tarball, but I get this:

--------------------------------------------------
[ 42%] Generating fa_IR.gmo
cd /tmp/guix-build-jami-202006-guix.drv-0/source &&
/gnu/store/n9wx4dp68bfsw9bb1bwmklzl34ggrmgm-gettext-minimal-0.20.1/bin/msgfmt
-o /tmp/guix-build-jami-202006-guix.drv-0/build/fa_IR.gmo
/tmp/guix-build-jami-202006-guix.drv-0/source/po/fa_IR.po make[2]:
Leaving directory '/tmp/guix-build-jami-202006-guix.drv-0/build' [ 42%]
Built target pofiles_18 make -f CMakeFiles/pofiles_19.dir/build.make
CMakeFiles/pofiles_19.dir/depend make[2]: Entering directory
'/tmp/guix-build-jami-202006-guix.drv-0/build' cd
/tmp/guix-build-jami-202006-guix.drv-0/build &&
/gnu/store/89rj5fqcg48afgk99639ds602pgf92k4-cmake-minimal-3.16.5/bin/cmake
-E cmake_depends "Unix Makefiles"
/tmp/guix-build-jami-202006-guix.drv-0/source
/tmp/guix-build-jami-202006-guix.drv-0/source
/tmp/guix-build-jami-202006-guix.drv-0/build
/tmp/guix-build-jami-202006-guix.drv-0/build
/tmp/guix-build-jami-202006-guix.drv-0/build/CMakeFiles/pofiles_19.dir/DependInfo.cmake
--color= Scanning dependencies of target pofiles_19 make[2]: Leaving
directory '/tmp/guix-build-jami-202006-guix.drv-0/build' make -f
CMakeFiles/pofiles_19.dir/build.make CMakeFiles/pofiles_19.dir/build
make[2]: Entering directory
'/tmp/guix-build-jami-202006-guix.drv-0/build' make[2]: Leaving
directory '/tmp/guix-build-jami-202006-guix.drv-0/build' make[1]: ***
[CMakeFiles/Makefile2:1258: CMakeFiles/jami-gnome.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs.... [ 43%] Generating fi.gmo
cd /tmp/guix-build-jami-202006-guix.drv-0/source &&
/gnu/store/n9wx4dp68bfsw9bb1bwmklzl34ggrmgm-gettext-minimal-0.20.1/bin/msgfmt
-o /tmp/guix-build-jami-202006-guix.drv-0/build/fi.gmo
/tmp/guix-build-jami-202006-guix.drv-0/source/po/fi.po make[2]: Leaving
directory '/tmp/guix-build-jami-202006-guix.drv-0/build' [ 43%] Built
target pofiles_19 make[1]: Leaving directory
'/tmp/guix-build-jami-202006-guix.drv-0/build' make: *** [Makefile:133:
all] Error 2 command "make" "-j" "2" failed with status 2 builder for
`/gnu/store/xczkspq41swhibf62mz6vcn624z1a3x6-jami-202006-guix.drv'
failed with exit code 1 build of
/gnu/store/xczkspq41swhibf62mz6vcn624z1a3x6-jami-202006-guix.drv failed
View build log at
'/var/log/guix/drvs/xc/zkspq41swhibf62mz6vcn624z1a3x6-jami-202006-guix.drv.bz2'.
guix build: error: build of
`/gnu/store/xczkspq41swhibf62mz6vcn624z1a3x6-jami-202006-guix.drv'
failed
----------------------------------------------------------

Can someone take a look on this?
Here's the source code:
https://gitlab.com/kromka_chleba/jami-package-and-other-things-for-guix/-/tree/wip-jami-from-git
https://gitlab.com/kromka_chleba/jami-package-and-other-things-for-guix.git
wip-jami-from-git branch
I also attached the full log.


Jan Wielkiewicz


[-- Attachment #2: zkspq41swhibf62mz6vcn624z1a3x6-jami-202006-guix.drv --]
[-- Type: application/octet-stream, Size: 148118 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-18  0:35 Jami bug source investigation #4 Jan Wielkiewicz
@ 2020-06-18  6:52 ` Pierre Neidhardt
  2020-06-18 18:22   ` Jan
                     ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Pierre Neidhardt @ 2020-06-18  6:52 UTC (permalink / raw)
  To: Jan Wielkiewicz, guix-devel

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Weird, there is no "Error 1".
Maybe try disabling parallel builds.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-18  6:52 ` Pierre Neidhardt
@ 2020-06-18 18:22   ` Jan
  2020-06-19 23:21   ` Jan Wielkiewicz
  2020-06-21  0:38   ` Jan Wielkiewicz
  2 siblings, 0 replies; 12+ messages in thread
From: Jan @ 2020-06-18 18:22 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

Dnia 2020-06-18, o godz. 08:52:26
Pierre Neidhardt <mail@ambrevar.xyz> napisał(a):

> Weird, there is no "Error 1".
Now there is :)
> Maybe try disabling parallel builds.
Didn't help, now it fails somewhere else:

--------------------------------------------------------
[ 36%] Generating ui/ui.gresource.c
cd /tmp/guix-build-jami-202006-guix.drv-0/source/ui &&
/gnu/store/kgdq89g6h3mjclxf3zb0sp7lz0yslrd4-glib-2.62.6-bin/bin/glib-compile-resources
--generate-source
--target=/tmp/guix-build-jami-202006-guix.drv-0/build/ui/ui.gresource.c
/tmp/guix-build-jami-202006-guix.drv-0/source/ui/ui.gresource.xml
make[2]: *** No rule to make target
'/tmp/guix-build-jami-202006-guix.drv-0/source/web/web.gresource.xml',
needed by 'web/web.gresource.c'.  Stop. make[2]: Leaving directory
'/tmp/guix-build-jami-202006-guix.drv-0/build' make[1]: ***
[CMakeFiles/Makefile2:1258: CMakeFiles/jami-gnome.dir/all] Error 2
make[1]: Leaving directory
'/tmp/guix-build-jami-202006-guix.drv-0/build' make: *** [Makefile:133:
all] Error 2 command "make" failed with status 2 builder for
`/gnu/store/66cihl0vgkq5bh49mhqyqr21rgnc9pg2-jami-202006-guix.drv'
failed with exit code 1 build of
/gnu/store/66cihl0vgkq5bh49mhqyqr21rgnc9pg2-jami-202006-guix.drv failed
View build log at
'/var/log/guix/drvs/66/cihl0vgkq5bh49mhqyqr21rgnc9pg2-jami-202006-guix.drv.bz2'.
----------------------------------------------------------

I attached the full log.

Jan Wielkiewicz

[-- Attachment #2: cihl0vgkq5bh49mhqyqr21rgnc9pg2-jami-202006-guix.drv --]
[-- Type: application/octet-stream, Size: 139391 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-18  6:52 ` Pierre Neidhardt
  2020-06-18 18:22   ` Jan
@ 2020-06-19 23:21   ` Jan Wielkiewicz
  2020-06-21  0:38   ` Jan Wielkiewicz
  2 siblings, 0 replies; 12+ messages in thread
From: Jan Wielkiewicz @ 2020-06-19 23:21 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: guix-devel

Hello,

it turns out there is a directory in libringclient package -
include/libringclient/web-chatview and it contains the missing files,
including the "web.gresource.xml" make and configure complain about.
I need to copy the files from include/libringclient/web-chatview of
libringclient package to source/web/ of jami package.
How do I do this? I tried using modify-phases and just copying the
files, but it fails in the same manner, while in the build directory
obtained using "--keep-failed", there are only links to the files.


Jan Wielkiewicz


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-18  6:52 ` Pierre Neidhardt
  2020-06-18 18:22   ` Jan
  2020-06-19 23:21   ` Jan Wielkiewicz
@ 2020-06-21  0:38   ` Jan Wielkiewicz
  2020-06-22  7:32     ` Pierre Neidhardt
  2 siblings, 1 reply; 12+ messages in thread
From: Jan Wielkiewicz @ 2020-06-21  0:38 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: guix-devel

Nevermind, I resolved the issue.
Jami built from git repository instead of from tarball didn't fix the
bug with audio call.


Jan Wielkiewicz


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-21  0:38   ` Jan Wielkiewicz
@ 2020-06-22  7:32     ` Pierre Neidhardt
  2020-06-22 12:23       ` Jan Wielkiewicz
  0 siblings, 1 reply; 12+ messages in thread
From: Pierre Neidhardt @ 2020-06-22  7:32 UTC (permalink / raw)
  To: Jan Wielkiewicz; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

Great!  Does this fix any other issue?
Does it warrant a package upgrade in Guix?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-22  7:32     ` Pierre Neidhardt
@ 2020-06-22 12:23       ` Jan Wielkiewicz
  2020-06-22 12:37         ` Pierre Neidhardt
  2020-07-05 20:29         ` Christopher Baines
  0 siblings, 2 replies; 12+ messages in thread
From: Jan Wielkiewicz @ 2020-06-22 12:23 UTC (permalink / raw)
  To: Pierre Neidhardt; +Cc: guix-devel

On Mon, 22 Jun 2020 09:32:50 +0200
Pierre Neidhardt <mail@ambrevar.xyz> wrote:

> Great!  Does this fix any other issue?
> Does it warrant a package upgrade in Guix?
> 

This alone didn't fix the problem, but as no other possibility was left
than broken pjproject, I tried to fix it and succeeded.
It is mandatory to pass "-DNDBUG" flag to turn off assertion.
https://trac.pjsip.org/repos/wiki/FAQ#Performance
https://trac.pjsip.org/repos/wiki/FAQ#assert

"Release mode. Don't forget to set the appropriate compiler
optimization flag, and disable assertion with -DNDEBUG."

This surely fixes the bug the reason of I was chasing for several
months, where after disconnecting from audio call, the daemon
"crashed" (asserted).
It is also possible this fixes some other issues with SIP, I didn't
test, because I was uninterested.

I'll prepare my messy code for committing once I have more time.

I'm not sure whether I should fetch from git or use a tarball after
doing all this work. Fetching from git adds more complexity to the
packages, but it gives me more control over it plus I'm not sure if I
can trust the tarballs anymore, after two cases where some files/folders
were missing.

Once I'll send the patches, would be cool if someone tested it.



Jan Wielkiewicz


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-22 12:23       ` Jan Wielkiewicz
@ 2020-06-22 12:37         ` Pierre Neidhardt
  2020-07-05 20:29         ` Christopher Baines
  1 sibling, 0 replies; 12+ messages in thread
From: Pierre Neidhardt @ 2020-06-22 12:37 UTC (permalink / raw)
  To: Jan Wielkiewicz; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> writes:

> I'm not sure whether I should fetch from git or use a tarball after
> doing all this work. Fetching from git adds more complexity to the
> packages, but it gives me more control over it plus I'm not sure if I
> can trust the tarballs anymore, after two cases where some files/folders
> were missing.

Then it seems reasonable to fetch from Git.

> Once I'll send the patches, would be cool if someone tested it.

Will do, thanks again for your work!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-06-22 12:23       ` Jan Wielkiewicz
  2020-06-22 12:37         ` Pierre Neidhardt
@ 2020-07-05 20:29         ` Christopher Baines
  2020-07-06  0:30           ` Jan Wielkiewicz
                             ` (2 more replies)
  1 sibling, 3 replies; 12+ messages in thread
From: Christopher Baines @ 2020-07-05 20:29 UTC (permalink / raw)
  To: Jan Wielkiewicz; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]


Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl> writes:

> On Mon, 22 Jun 2020 09:32:50 +0200
> Pierre Neidhardt <mail@ambrevar.xyz> wrote:
>
>> Great!  Does this fix any other issue?
>> Does it warrant a package upgrade in Guix?
>> 
>
> This alone didn't fix the problem, but as no other possibility was left
> than broken pjproject, I tried to fix it and succeeded.
> It is mandatory to pass "-DNDBUG" flag to turn off assertion.
> https://trac.pjsip.org/repos/wiki/FAQ#Performance
> https://trac.pjsip.org/repos/wiki/FAQ#assert
>
> "Release mode. Don't forget to set the appropriate compiler
> optimization flag, and disable assertion with -DNDEBUG."
>
> This surely fixes the bug the reason of I was chasing for several
> months, where after disconnecting from audio call, the daemon
> "crashed" (asserted).
> It is also possible this fixes some other issues with SIP, I didn't
> test, because I was uninterested.
>
> I'll prepare my messy code for committing once I have more time.
>
> I'm not sure whether I should fetch from git or use a tarball after
> doing all this work. Fetching from git adds more complexity to the
> packages, but it gives me more control over it plus I'm not sure if I
> can trust the tarballs anymore, after two cases where some files/folders
> were missing.
>
> Once I'll send the patches, would be cool if someone tested it.

So, I tried adding -DNDEBUG to the CFLAGS bit of the #:configure-flags,
and the package built. Testing it out seems to work, I think I've
experienced this issue with assertion failures, so hopefully this will
help.

modified   gnu/packages/jami.scm
@@ -141,7 +141,7 @@
              ;; against pjproject-jami:
              ;;   relocation R_X86_64_32S against `.rodata' can not be used when
              ;;   making a shared object;
-             "CFLAGS=-fPIC"
+             "CFLAGS=-fPIC -DNDEBUG"
              "CXXFLAGS=-fPIC")
        #:phases
        (modify-phases %standard-phases


Is there more to applying this fix, or will this change alone help? I'm
more than happy to review patches.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-07-05 20:29         ` Christopher Baines
@ 2020-07-06  0:30           ` Jan Wielkiewicz
  2020-07-06  1:23           ` Jan Wielkiewicz
  2020-07-06 15:52           ` Jan Wielkiewicz
  2 siblings, 0 replies; 12+ messages in thread
From: Jan Wielkiewicz @ 2020-07-06  0:30 UTC (permalink / raw)
  To: Christopher Baines; +Cc: guix-devel

Hi,

On Sun, 05 Jul 2020 21:29:33 +0100
Christopher Baines <mail@cbaines.net> wrote:
> 
> So, I tried adding -DNDEBUG to the CFLAGS bit of the
> #:configure-flags, and the package built. Testing it out seems to
> work, I think I've experienced this issue with assertion failures, so
> hopefully this will help.
> 
> modified   gnu/packages/jami.scm
> @@ -141,7 +141,7 @@
>               ;; against pjproject-jami:
>               ;;   relocation R_X86_64_32S against `.rodata' can not
> be used when ;;   making a shared object;
> -             "CFLAGS=-fPIC"
> +             "CFLAGS=-fPIC -DNDEBUG"
>               "CXXFLAGS=-fPIC")
>         #:phases
>         (modify-phases %standard-phases
> 
> Is there more to applying this fix, or will this change alone help?
> I'm more than happy to review patches.
> 
> Thanks,
> 
> Chris

That's it for the bug, if you want to have it fixed quickly, feel free
to commit it. I didn't do it yet, because I'm busy writting commit
messages for my refactored and updated package definitions.
I'm also trying to catch up with the latest Jami version - they fixed
some annoying stuff too.

Is there a script for automatically writing commit messages compliant
with the GNU coding standards?


Jan Wielkiewicz


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-07-05 20:29         ` Christopher Baines
  2020-07-06  0:30           ` Jan Wielkiewicz
@ 2020-07-06  1:23           ` Jan Wielkiewicz
  2020-07-06 15:52           ` Jan Wielkiewicz
  2 siblings, 0 replies; 12+ messages in thread
From: Jan Wielkiewicz @ 2020-07-06  1:23 UTC (permalink / raw)
  To: Christopher Baines; +Cc: guix-devel

Nevermind, I've managed to write *I hope good commit messages*.
Do not commit the fix yet, I will send all patches tomorrow.


Jan Wielkiewcz


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Jami bug source investigation #4
  2020-07-05 20:29         ` Christopher Baines
  2020-07-06  0:30           ` Jan Wielkiewicz
  2020-07-06  1:23           ` Jan Wielkiewicz
@ 2020-07-06 15:52           ` Jan Wielkiewicz
  2 siblings, 0 replies; 12+ messages in thread
From: Jan Wielkiewicz @ 2020-07-06 15:52 UTC (permalink / raw)
  To: Christopher Baines; +Cc: guix-devel

Hi,

I sent the patches to the mailing list.
They should be soon available here:
https://lists.gnu.org/archive/html/guix-patches/2020-07/msg00153.html


Jan Wielkiewicz


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, back to index

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18  0:35 Jami bug source investigation #4 Jan Wielkiewicz
2020-06-18  6:52 ` Pierre Neidhardt
2020-06-18 18:22   ` Jan
2020-06-19 23:21   ` Jan Wielkiewicz
2020-06-21  0:38   ` Jan Wielkiewicz
2020-06-22  7:32     ` Pierre Neidhardt
2020-06-22 12:23       ` Jan Wielkiewicz
2020-06-22 12:37         ` Pierre Neidhardt
2020-07-05 20:29         ` Christopher Baines
2020-07-06  0:30           ` Jan Wielkiewicz
2020-07-06  1:23           ` Jan Wielkiewicz
2020-07-06 15:52           ` Jan Wielkiewicz

unofficial mirror of guix-devel@gnu.org 

Archives are clonable:
	git clone --mirror https://yhetil.org/guix-devel/0 guix-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-devel guix-devel/ https://yhetil.org/guix-devel \
		guix-devel@gnu.org
	public-inbox-index guix-devel

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.devel
	nntp://news.gmane.io/gmane.comp.gnu.guix.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git