From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4IlZAGeunmGcewAAgWs5BA (envelope-from ) for ; Wed, 24 Nov 2021 22:28:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4Dm9N2aunmEQSQAA1q6Kng (envelope-from ) for ; Wed, 24 Nov 2021 21:28:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 955912B9E3 for ; Wed, 24 Nov 2021 22:28:06 +0100 (CET) Received: from localhost ([::1]:48168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpzoD-0008Em-H1 for larch@yhetil.org; Wed, 24 Nov 2021 16:28:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpznP-0008Bv-ON for guix-devel@gnu.org; Wed, 24 Nov 2021 16:27:15 -0500 Received: from [2600:3c01:e000:267:0:a171:de7:c] (port=46466 helo=cascadia.aikidev.net) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpznN-0001Ek-Nz; Wed, 24 Nov 2021 16:27:15 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 49D301A982; Wed, 24 Nov 2021 13:27:12 -0800 (PST) From: Vagrant Cascadian To: Philip McGrath , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Subject: Re: default tar format for "make dist" and patch file length In-Reply-To: <87tug7jtba.fsf@ponder> References: <87sfvxhrav.fsf@ponder> <874k8bxbit.fsf@gnu.org> <87fsru8l05.fsf@ponder> <87czmy8hr6.fsf@ponder> <87y25kjiwa.fsf@gnu.org> <071f69a4-4e8a-3337-6a84-6ceca5119e6f@philipmcgrath.com> <87tug7jtba.fsf@ponder> Date: Wed, 24 Nov 2021 13:27:03 -0800 Message-ID: <87zgpt453s.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2600:3c01:e000:267:0:a171:de7:c (failed) Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, 51985@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637789286; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=smEgAG+h1+nfugxxtdhT0S3aEHb7T3013luXy9MtW4o=; b=I/HpymBe2IJoSX4xEg1OIotbkhmibI2R0myJM+3UGueF4cFl6wvSFMYdi+GcBFzqmZ6SIc 2/GyPSYc8aZz0O8x2UAz1EMkk6EO74B2RdZKTNG0TdyIPRawagfQF6UiDH+EdN/aAGm5KB aE8qRs8GJHxeHHkaI+/tGw6r8Ew0Gqhc6nXAuXcNdvR2Y2xF/7IqMwdWpZpyEbK1FrTHaV iN0tnBrOL3yuEO16qu0x1swgJk6jpJqlF1Vh5VzaERFLGFzJh6djk5gycLin/YlaRbHpGs +xXoH6kTVTppLmE0tlpTIfRE13wf+5h/Pc9AV+KxmbK+q4RgBX+H56QzqRDaTQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637789286; a=rsa-sha256; cv=none; b=q45hlD7TiBU1HQVAo7XJvULCILyx5JubKh8nSjgiv8rwaS+E+iDHh5DAUaxFm5J9flGMGl WjxylTmSH/afpRhKoKVDRACI1o6G91H6J/dSww/CeyVlLFzIS8ToIr1YeV89VTRBlkAdp5 3s9U2iRqMF+MdKpDfot0Vs0q+EsogUUkKhfq0oO5mBI0URkNPYKHr2zQV1LkHUELi502tv IKIfrB+cr/Ij+FBEmrhIQvnqhgGQVDK1fyng3U5gbDfMyd71ixhmO+erTbJzjRArxQjC70 O7I6pRhUsERucByLVfZqcKx7r/ZnBFq6I9FAq2+ecHhEuq/dmJevLQhuOvzXVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.49 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 955912B9E3 X-Spam-Score: -4.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: NTtnIaaDBIyc --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-19, Vagrant Cascadian wrote: > On 2021-11-19, Philip McGrath wrote: >> On 11/19/21 09:54, Ludovic Court=C3=A8s wrote: >>> Vagrant Cascadian skribis: >>>> So, I guess I'm leaning towards making the guix lint check a little mo= re >>>> lenient. >>>> >>>> Thoughts? >>>=20 >>> That sounds even better, I=E2=80=99m all for it (changing (guix lint) += fixing >>> the two remaining issues)! > > Submitted the guix lint change as https://issues.guix.gnu.org/51775 Er, I meant: https://issues.guix.gnu.org/51985 >> It might also help to change the warning given by the check. >> >> When a program called "lint" tells me that something is too long, I=20 >> understand that to mean that what I've done is generally considered bad= =20 >> style, but there might be a very good reason to do it in some specific=20 >> case. For example, I might exceed a line length guideline to avoid=20 >> inserting linebreaks into a URL. > > That's a good point! > > >> If instead `guix lint` is telling us about a hard limit that will break= =20 >> things, I think it should say so clearly. > > Not sure how to convey succinctly, but here's an attempt at a patch > (which ironically also probably makes the line a bit too long in the > code): > > diff --git a/guix/lint.scm b/guix/lint.scm > index ac2e7b3841..6464fb751a 100644 > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name) > max) > (make-warning > package > - (G_ "~a: file name is too long") > + (G_ "~a: file name is too long and may break = release tarball generation") > (list (basename patch)) > #:field 'patch-file-names) > #f)) > diff --git a/tests/lint.scm b/tests/lint.scm > index 9a91dd5426..d4c3d62aaf 100644 > --- a/tests/lint.scm > +++ b/tests/lint.scm > @@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs > "hsab") > (test-equal "patches: file name too long" > (string-append "x-" > (make-string 100 #\a) > - ".patch: file name is too long") > + ".patch: file name is too long and may break release ta= rball generation") > (single-lint-warning-message > (let ((pkg (dummy-package > "x" live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYZ6uKwAKCRDcUY/If5cW qlNPAQCKSp3tT9jJrGVN6CQqrVTvtXBEYopDyUtXS6Px0WRSegEAqfVuvxPRoVRv VA5clCc8ynDcuDWATqqpgZGvkGgoCg8= =kuOO -----END PGP SIGNATURE----- --=-=-=--