From: Vagrant Cascadian <vagrant@debian.org>
To: "Philip McGrath" <philip@philipmcgrath.com>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org, 51985@debbugs.gnu.org
Subject: Re: default tar format for "make dist" and patch file length
Date: Wed, 24 Nov 2021 13:27:03 -0800 [thread overview]
Message-ID: <87zgpt453s.fsf@ponder> (raw)
In-Reply-To: <87tug7jtba.fsf@ponder>
[-- Attachment #1: Type: text/plain, Size: 2495 bytes --]
On 2021-11-19, Vagrant Cascadian wrote:
> On 2021-11-19, Philip McGrath wrote:
>> On 11/19/21 09:54, Ludovic Courtès wrote:
>>> Vagrant Cascadian <vagrant@debian.org> skribis:
>>>> So, I guess I'm leaning towards making the guix lint check a little more
>>>> lenient.
>>>>
>>>> Thoughts?
>>>
>>> That sounds even better, I’m all for it (changing (guix lint) + fixing
>>> the two remaining issues)!
>
> Submitted the guix lint change as https://issues.guix.gnu.org/51775
Er, I meant: https://issues.guix.gnu.org/51985
>> It might also help to change the warning given by the check.
>>
>> When a program called "lint" tells me that something is too long, I
>> understand that to mean that what I've done is generally considered bad
>> style, but there might be a very good reason to do it in some specific
>> case. For example, I might exceed a line length guideline to avoid
>> inserting linebreaks into a URL.
>
> That's a good point!
>
>
>> If instead `guix lint` is telling us about a hard limit that will break
>> things, I think it should say so clearly.
>
> Not sure how to convey succinctly, but here's an attempt at a patch
> (which ironically also probably makes the line a bit too long in the
> code):
>
> diff --git a/guix/lint.scm b/guix/lint.scm
> index ac2e7b3841..6464fb751a 100644
> --- a/guix/lint.scm
> +++ b/guix/lint.scm
> @@ -968,7 +968,7 @@ (define (starts-with-package-name? file-name)
> max)
> (make-warning
> package
> - (G_ "~a: file name is too long")
> + (G_ "~a: file name is too long and may break release tarball generation")
> (list (basename patch))
> #:field 'patch-file-names)
> #f))
> diff --git a/tests/lint.scm b/tests/lint.scm
> index 9a91dd5426..d4c3d62aaf 100644
> --- a/tests/lint.scm
> +++ b/tests/lint.scm
> @@ -509,7 +509,7 @@ (define hsab (string-append (assoc-ref inputs
> "hsab")
> (test-equal "patches: file name too long"
> (string-append "x-"
> (make-string 100 #\a)
> - ".patch: file name is too long")
> + ".patch: file name is too long and may break release tarball generation")
> (single-lint-warning-message
> (let ((pkg (dummy-package
> "x"
live well,
vagrant
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2021-11-24 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 0:34 default tar format for "make dist" and patch file length Vagrant Cascadian
2021-11-17 11:32 ` Ludovic Courtès
2021-11-17 22:39 ` Vagrant Cascadian
2021-11-17 23:49 ` Vagrant Cascadian
2021-11-19 14:54 ` Ludovic Courtès
2021-11-20 4:39 ` Philip McGrath
2021-11-20 5:21 ` Vagrant Cascadian
2021-11-24 21:27 ` Vagrant Cascadian [this message]
2021-11-22 2:03 ` Maxim Cournoyer
2021-11-22 11:31 ` Ludovic Courtès
2021-11-22 20:14 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgpt453s.fsf@ponder \
--to=vagrant@debian.org \
--cc=51985@debbugs.gnu.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=philip@philipmcgrath.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).