From: "Ludovic Courtès" <ludo@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: RFC: new syntax for inline patches
Date: Sat, 08 Jan 2022 22:34:15 +0100 [thread overview]
Message-ID: <87zgo53oa0.fsf@gnu.org> (raw)
In-Reply-To: <87ee5ne7z5.fsf@elephly.net> (Ricardo Wurmus's message of "Tue, 04 Jan 2022 17:50:31 +0100")
Hi!
Ricardo Wurmus <rekado@elephly.net> skribis:
> (arguments
> (list
> #:phases
> '(modify-phases %standard-phases
> (add-after 'unpack 'i-dont-care
> (lambda _
> (substitute* "this-file"
> (("^# some unique string, oh, careful! gotta \\(escape\\) this\\." m)
> (string-append m "\nI ONLY WANTED TO ADD THIS LINE!\n"))))))))
[...]
> There are a few reasons why we don’t use patches as often:
>
> 1. the source code is precious and we prefer to modify the original
> sources as little as necessary, so that users can get the source code as
> upstream intended with “guix build -S foo”. We patch the sources
> primarily to get rid of bundled source code, pre-built binaries, or
> code that encroaches on users’ freedom.
>
> 2. the (patches …) field uses patch files. These are annoying and
> inflexible. They have to be added to dist_patch_DATA in gnu/local.mk,
> and they cannot contain computed store locations. They are separate
> from the package definition, which is inconvenient.
>
> 3. snippets feel like less convenient build phases. Snippets are not
> thunked, so we can’t do some things that we would do in a build phase
> substitution. We also can’t access %build-inputs or %outputs. (I don’t
> know if we can use Gexps there.)
I agree that #1 is overrated.
As for #3, we could make ‘snippet’ thunked (a snippet can be a gexp
already). We cannot refer to build inputs there, but that’s on purpose:
snippets, like patches, are supposed to be architecture-independent and
unable to insert store file names.
[...]
> (We have something remotely related in etc/committer.scm.in, where we
> define a record describing a diff hunk.)
>
> Here’s a colour sample for the new bikeshed:
>
> (arguments
> (list
> #:patches
> #~(patch "the-file"
> ((line 10)
> (+ "I ONLY WANTED TO ADD THIS LINE"))
> ((line 3010)
> (- "maybe that’s better")
> (+ (string-append #$guix " is better"))
> (+ "but what do you think?")))))
Like Attila my first reaction was skepticism.
… but thinking about it, we could have a <computed-patch> record,
similar to the <diff-hunk> record you mention; it would be a file-like
object that, when lowered, would give an actual patch.
So you could write:
(origin
;; …
(patches (list (computed-patch
(hunk (line 10) (+ "new line") (- "old line"))))))
The good thing is that the implementation of <computed-patch> would be
entirely orthogonal, separate from the package machinery.
OTOH, if we do that, we might as well write the actual patch right away.
I wonder how frequent the pattern we’re discussing is. I know I’ve used
it a few times, but I wonder if it warrants sophisticated tooling.
Thoughts?
Ludo’.
next prev parent reply other threads:[~2022-01-08 21:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 16:50 RFC: new syntax for inline patches Ricardo Wurmus
2022-01-05 8:16 ` Attila Lendvai
2022-01-06 0:19 ` Liliana Marie Prikler
2022-01-06 1:20 ` Jelle Licht
2022-01-06 6:43 ` Liliana Marie Prikler
2022-01-06 7:12 ` Ricardo Wurmus
2022-01-06 8:12 ` Liliana Marie Prikler
2022-01-08 21:34 ` Ludovic Courtès [this message]
2022-01-12 18:06 ` Efraim Flashner
2022-01-12 17:56 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgo53oa0.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).