From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KAQqJxMNTGIhdAAAgWs5BA (envelope-from ) for ; Tue, 05 Apr 2022 11:34:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4Jv1JBMNTGKeLAAA9RJhRA (envelope-from ) for ; Tue, 05 Apr 2022 11:34:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 541CD674 for ; Tue, 5 Apr 2022 11:34:11 +0200 (CEST) Received: from localhost ([::1]:41000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbfZi-00080t-El for larch@yhetil.org; Tue, 05 Apr 2022 05:34:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nbfX5-0005tT-VI for guix-devel@gnu.org; Tue, 05 Apr 2022 05:31:31 -0400 Received: from mira.cbaines.net ([212.71.252.8]:36332) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nbfX4-0003fT-Ah for guix-devel@gnu.org; Tue, 05 Apr 2022 05:31:27 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 075E027BBE9; Tue, 5 Apr 2022 10:31:23 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 6619ea78; Tue, 5 Apr 2022 09:31:23 +0000 (UTC) References: <164904612874.946.17349166055621457713@vcs2.savannah.gnu.org> <20220404042210.082F1C01684@vcs2.savannah.gnu.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Christopher Baines To: Maxim Cournoyer Subject: Re: 06/07: gnu: git: Update to 2.35.1. Date: Tue, 05 Apr 2022 10:23:38 +0100 In-reply-to: <20220404042210.082F1C01684@vcs2.savannah.gnu.org> Message-ID: <87zgkzop06.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, 53751@debbugs.gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649151251; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=RYjp8EiJrk2Nipq1w4vq5uuFotxgRymj5BG3r5xZtEw=; b=r9HbqCJYIqJ5LzKGX/mScs0b1LINKNc19345tHD6/fEjceybdaVBtJh5e6WZ35RnxmAdJu /PIEfJ6pL6No6xy7IiGApubb8urM489xqmyQozTV/pZsRMdXawSY/0ptPhsF+m7ygMi14j 32HpkMBseYzNLue2R9fQBAJLgENPJVJA/t4B/OqpUeySWD65dPxuL78lRxoz4seHZ8P5Kd KxnVZVSxWoX1ZEngKFUoub/sm3aGeXfnmW6lRdA8Dq5thv0muItT/ywHGj/EQGFYXOZnP7 fs3/n0t4G45xohsXlnSvdyL9gYV8koMYZhM1Jfn7dCOajwEGgvb1YEdkecCGgg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649151251; a=rsa-sha256; cv=none; b=mXtvt5asR4ZMC3eIqM/p3LtynEUOAMUO/AJq29jnXwuMmX61Py9Pu0gzfsr3ZGEcATfIqb Y0tDjLYc1i3DF+UH1GDqAqow/0IPyTqpZ1WLgBAimQFsxvVl7EaXci92+7iXOvAJaX1rIP JreQIM9WOznhkjfDMZnpUoT39aOpXpwDcSSsIyUCptiTNeCBV6HK60F+f8nDwK6IApQ2Ar ZYeVm8M6rEuNWZCqI5stfKQzXBkmT7i22NuV5ekmIwoQJWw8aRoBR35yJlsrTVg214KwPo JQgsZoWso7lf73I+1CxFVmyga3l8NyzYArtw9rbyUH+97LSZMchs410U44/whQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.27 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 541CD674 X-Spam-Score: -6.27 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1H2r+AtUn7/o --=-=-= Content-Type: text/plain guix-commits@gnu.org writes: > apteryx pushed a commit to branch master > in repository guix. > > commit 223a3d7f7fdb6af9c4c090785cab15d38680e887 > Author: Maxim Cournoyer > AuthorDate: Mon Apr 4 00:06:48 2022 -0400 > > gnu: git: Update to 2.35.1. > > * gnu/packages/version-control.scm (git): Update to 2.35.1. > [phases]: Delete trailing #t. > > Signed-off-by: Maxim Cournoyer > Modified-by: Maxim Cournoyer I've been looking in to this commit, since I noticed a large number of rebuilds. It looks connected to Greg's patch submitted in Issue #53751, but rather than being authored by Greg, it's authored by Maxim. Additionally, I'm guessing that the changes in Greg's patch are much less impactful in terms of rebuilds compared to this commit, which also removes the trailing #t from the phases, which will have affected every variant of the git package, including variants like git-minimal/fixed, which as the commit in the code says, is intended to rarely change. I'm all for making changes fast, but I'm not sure the removal of #t from the phases in thisq package definition is worth the cost of the thousands of package rebuilds on the master branch. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmJMDGlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xcg5g/+NA6lYc9yqDcskZ7ycVwZtK9lUVe4tfVN vN9HsViP5roSS3NC/8W6VWiwSQzFF7KbcaPmawq34LnmGvNpLQWp4CdR+mjhPIOl U9h3vKbP1yVhsBUsbkYD3QYiyjzeEJg/c8S/ij1BQihFoDyoj6Bzk6cb8+zAf0rg E90W0cvfpbVmgQnMVAfe5bbLUbvZSRScTdWlDvcZQ9Pjdp+g6RctCQKBMcWQ4d3o Ny/wjA7hbuz+F6+PZtancXwtX88uuRjaoM7BZF1KFT79f727UEQVBjutBfhEAz9n h78lijI3nNWnIip8JNfqu6SmRz8ykMI4wl1DBP7kq+CkyMhOve4A7I6IEsMLI5xL t0gE0MrOIJKMr0yNhah86ArUY4F1+P2l3EHzl7DsB9in3nNp5hWggIEcoHCLLtmn WoJZ7cKN/HWUP6Re20NZ0FEAKNkDNr+BJZbqN7V3cLxQ2/lW1I/S6BunPhphny0v nCW/FgrWeYIpcPKLynD+RkV2dzBZ8z+2OfFOBieIRyk9aKZNCPyOhT5xePE1tb0w PiWRTTHpVrn/sqh8MpVM2spyolHos0OAEyYR/lyCA+1I96JJvOflWn6BboIFLxbR ARgstpd5nBHphMwipMHVLShDc1XlDGAxgCD960Kc+K4QzM1JZK9/ffEju8Pv2HOc dJkTCQGpzPg= =Iwiv -----END PGP SIGNATURE----- --=-=-=--