From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id uB1UMOYAEmWQEgEAauVa8A:P1 (envelope-from ) for ; Mon, 25 Sep 2023 23:51:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uB1UMOYAEmWQEgEAauVa8A (envelope-from ) for ; Mon, 25 Sep 2023 23:51:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 77F8040567 for ; Mon, 25 Sep 2023 23:51:34 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b=cCdTeJDL; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695678694; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ECDiB9jKSdcTOW6CQuDGtRvm0TPmRnq/DmhX7oHjoYU=; b=R+t+p0rnUSz2GeyOWzYhRGXRjCVVsnh3VjncBFFIBp4QL1TIHdu4yc8xIE/bqUu+d/AKIb ESkfbFSswgKJgc9Le6UvGpx32PSRrddsLd1TrwrJbsGaInx4g5C8QecVfQV1M6EEL1bmN2 Dj/haHAeqHmuSeYoYKhWnNr9u90bP+VUB6gpA8/SM2BEUrEoPWIvyNgwAdknJNvGjQP0n9 RgL+HuPS/YEMf5FDi9jb2HrqYm5/gddGlx4RP02GxfCOUJSJ0gT6Wzx8KJfHVph3g3e6N5 ZFaqckH8aoLTdvl/+9uQvZfvTthyRVu478YwiVnLjtyZh7SAXOQatdWtHbq8Hg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695678694; a=rsa-sha256; cv=none; b=sH0/6G5ecQjytU4FgcTya9tuzwGtiQfXN7Ck52ZBDHQFucGCpyLdLc/r7xsWNfhCKNOmjd k1ZvQ68k56fT98swVHcR32qPwqq0UanJmGzkHpgvBBNtE1fax2jBVEGwHHuTuND9U1xHMF dNLBZ572rMxWcsfQaB6WwrM+cCut8K+kytaBeF8soJ7NPsTOeAQIzMtHySjQFEnd52v+72 ppOVyfckwH8DV4eHiqjL/NP37tY/Ul7IA1ozeXNkUgQQgRWQVGNJJl6yBs2fqgQuOrW9XY LWPIHjN2F3rvzS1HScwgjfpMDpUNEiI91ncqPXwSmdH36kDDHBT0wmhRZTKCGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b=cCdTeJDL; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.de Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qktTd-0005dM-EO; Mon, 25 Sep 2023 17:50:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qktTZ-0005bI-Fy for guix-devel@gnu.org; Mon, 25 Sep 2023 17:50:45 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qktTO-0001gy-LH for guix-devel@gnu.org; Mon, 25 Sep 2023 17:50:44 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id AD98B240029 for ; Mon, 25 Sep 2023 23:50:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1695678630; bh=dqk1O6FystUqrDqEQwdhwf5PnVqTs2kT+FvPjm7WRU4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=cCdTeJDLwp3jfO8pKFI4nm+suaIasglLqJuVoMEwoTU8mlXE5vmHqyzTEaHfNvVtm qnkNp73eJ/Z+e37MkDgcHtyGAibSV6ZVA5IGS4TY4ZWS/cvP+EvE/eiQ9PeS+P+94R Njv6HE3IOJFjMVxNb+THL8Lsk2bW591Kq2CJAbl0mNg0A6gSpENj711bwmBZvhYLmW 7IoFCu2vvc5mBf+R5EK7XLKHd8fmWZZa8XelUviccTk4HiUZ0PtAqxJe7Kyzi2cAF8 m+Ib1c8xSrzIdqUjMnvr8uH0xfXTUDDOJJ8r1iNGRk4U9RpYyM0kiMxWSiJ9gRybAt BJa82zurBTAtQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rvc4Q08Qtz9s04; Mon, 25 Sep 2023 23:50:29 +0200 (CEST) References: <87bke07ccl.fsf@gmail.com> From: Mekeor Melire To: Maxim Cournoyer Cc: guix-devel@gnu.org Subject: Re: New section to easily reference Debbugs URLs within Emacs Debbugs Date: Mon, 25 Sep 2023 21:27:55 +0000 In-reply-to: <87bke07ccl.fsf@gmail.com> Message-ID: <87zg19udmy.fsf@posteo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=mekeor@posteo.de; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.75 X-Migadu-Spam-Score: -9.75 X-Migadu-Scanner: mx1.migadu.com X-Migadu-Queue-Id: 77F8040567 X-TUID: T3T8seZu9GzW --=-=-= Content-Type: text/plain; format=flowed 2023-09-17 16:51 maxim.cournoyer@gmail.com: > Hello, Hello Maxim, > If you use Emacs and Emacs-Debbugs, you may be interested in > applying the settings newly documented in the 'Viewing Bugs > within Emacs' section of the manual; see it at the bottom of > info "(guix) The Perfect Setup"). > > I hope that's useful, Thank you for sharing. The new section is very useful for me. I have two things to feed back though. First feedback: I think the new section should instruct to set the `bug-reference-url-format'. I.e. we should add this to the suggested code snippet: (setq bug-reference-url-format "https://issues.guix.gnu.org/%s"). Otherwise, the suggested code snippet results in an error when a bug reference is clicked. See appendix. Second feedback: It might be nice to write regular-expressions using the `rx' macro, but imho writing them as strings is shorter, unobtrusive and thus preferable for average Guix users. I.e. I'd suggest to replace the two setq-expressions of code that the new manual section suggests, with the following S-expressions respectively: (setq bug-reference-bug-regexp "\\(\\b\\(?:[Bb]ug ?#?\\|[Pp]atch ?#\\|[Ff]ixes:? ?#\\|RFE ?#\\|PR [+a-z-]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)\\|\\)") (setq debbugs-browse-url-regexp "^https?://\\(?:bugs\\|debbugs\\|issues\\.guix\\)\\.gnu\\.org/+\\(\\(?:cgi/bugreport\\.cgi\\?bug=\\)?\\)\\(?3:[[:digit:]]+\\)$") WDYT? --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=reproduce-error.el Content-Transfer-Encoding: quoted-printable ;; First, evaluate these, as described at : (require 'bug-reference) (require 'debbugs) (require 'debbugs-browse) (setq bug-reference-bug-regexp (rx (group (or (seq word-boundary (or (seq (char "Bb") "ug" (zero-or-one " ") (zero-or-one "#")) (seq (char "Pp") "atch" (zero-or-one " ") "#") (seq (char "Ff") "ixes" (zero-or-one ":") (zero-or-one " ") "#") (seq "RFE" (zero-or-one " ") "#") (seq "PR " (one-or-more (char "a-z+-")) "/")) (group (one-or-more (char "0-9")) (zero-or-one (seq "#" (one-or-more (char "0-9")))))) (seq ""))))) (setq debbugs-browse-url-regexp (rx line-start "http" (zero-or-one "s") "://" (or "debbugs" "issues.guix" "bugs") ".gnu.org" (one-or-more "/") (group (zero-or-one "cgi/bugreport.cgi?bug=3D")) (group-n 3 (one-or-more digit)) line-end)) (bug-reference-mode) (debbugs-browse-mode) ;; Finally, click this: [bug#66146]. For me, it does not work. It only prin= ts this error as message: "bug-reference-push-button: You must customize so= me bug-reference variables; see Emacs info node Bug Reference". But it does= work (i.e. open the respective bug in debbugs-browse within Emacs) after e= valuating the following S-expression: (setq bug-reference-url-format "https://issues.guix.gnu.org/%s") --=-=-=--