From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add SDL extension libraries
Date: Thu, 21 Nov 2013 13:23:17 +0100
Message-ID: <87y54iq6yy.fsf@gnu.org>
References: <528D745D.1040105@worcester.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56726)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VjTI4-0001El-JU
	for guix-devel@gnu.org; Thu, 21 Nov 2013 07:23:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VjTHz-0000y7-39
	for guix-devel@gnu.org; Thu, 21 Nov 2013 07:23:24 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:42740)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VjTHy-0000xv-Rx
	for guix-devel@gnu.org; Thu, 21 Nov 2013 07:23:18 -0500
In-Reply-To: <528D745D.1040105@worcester.edu> (David Thompson's message of
	"Wed, 20 Nov 2013 21:47:57 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> Attached is a patch to add the following extension libraries for SDL
> 1.x: SDL_gfx, SDL_image, SDL_mixer, SDL_net, and SDL_ttf.

Wow, cool.

Is the copyright/licensing of these packages clear?  In particular, do
all the files within each package have clearly the same license, or a
compatible license?  (I=E2=80=99d expect it to be the case given that SDL is
widespread, but just asking to be sure.)

> +(define sdl-image
> +  (package
> +    (name "sdl-image")
> +    (version "1.2.12")
> +    (source (origin
> +             (method url-fetch)
> +             (uri
> +              (string-append "http://www.libsdl.org/projects/SDL_image/r=
elease/SDL_image-"
> +                             version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "16an9slbb8ci7d89wakkmyfvp7c0cval8xw4hkg0842nhhlp540b"))))
> +    (build-system gnu-build-system)
> +    ;; FIXME: Add webp
> +    (propagated-inputs `(("sdl" ,sdl)
> +                         ("libpng" ,libpng)
> +                         ("libjpeg" ,libjpeg)
> +                         ("libtiff" ,libtiff)))

Are you sure that all these need to be propagated?

(An input typically needs to be propagated if an installed header
#includes a header of that input, or if the .pc file mentions that input
in its =E2=80=98Requires:=E2=80=99 field.)

Otherwise looks good to me!

Thanks,
Ludo=E2=80=99.