From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/6] gnu: Add libpeas.
Date: Sat, 30 Nov 2013 23:03:59 +0100
Message-ID: <87y545wnqo.fsf@gnu.org>
References: <1385774016-1418-1-git-send-email-tipecaml@gmail.com>
	<1385774016-1418-4-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Vmsdy-0006mZ-Vx
	for guix-devel@gnu.org; Sat, 30 Nov 2013 17:04:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Vmsdt-0008U8-0F
	for guix-devel@gnu.org; Sat, 30 Nov 2013 17:04:06 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:56456)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Vmsds-0008U4-Pm
	for guix-devel@gnu.org; Sat, 30 Nov 2013 17:04:00 -0500
In-Reply-To: <1385774016-1418-4-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Sat, 30 Nov 2013 02:13:33 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/gnome.scm (libpeas): New variable.

OK!

> +         (lambda* (#:key inputs #:allow-other-keys #:rest args)
> +          (let ((configure (assoc-ref %standard-phases 'configure))
> +                (gir-path (lambda (pkg-name)
> +                           (string-append
> +                            (assoc-ref inputs pkg-name)
> +                            "/share/gir-1.0"))))
> +           (substitute* "libpeas-gtk/Makefile.in"
> +            (("--add-include-path")
> +             (string-append
> +               " --add-include-path=3D" (gir-path "atk")
> +               " --add-include-path=3D" (gir-path "gdk-pixbuf")
> +               " --add-include-path=3D" (gir-path "gtk+")
> +               " --add-include-path=3D" (gir-path "pango")
> +              " --add-include-path")))

If this =E2=80=98gir-path=E2=80=99 thing is frequent, we should factorize i=
t in a
build-side module, say (guix build gnome).  WDYT?

(That shouldn=E2=80=99t block this particular patch, though.)

Ludo=E2=80=99.