From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: refresh: Add --list-upstream-closure option. Date: Fri, 18 Jul 2014 01:20:15 +0200 Message-ID: <87y4vrbmj4.fsf@gnu.org> References: <877g3fp5bc.fsf@member.fsf.org> <8738e2l3ws.fsf@gnu.org> <877g3d3rli.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7uya-0005zY-JR for guix-devel@gnu.org; Thu, 17 Jul 2014 19:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7uyI-00038g-0u for guix-devel@gnu.org; Thu, 17 Jul 2014 19:20:36 -0400 Received: from hera.aquilenet.fr ([2a01:474::1]:60411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7uyH-00038c-Pw for guix-devel@gnu.org; Thu, 17 Jul 2014 19:20:17 -0400 In-Reply-To: <877g3d3rli.fsf@gmail.com> (Eric Bavier's message of "Wed, 16 Jul 2014 16:45:45 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Eric Bavier Cc: guix-devel@gnu.org Eric Bavier skribis: > Ludovic Court=C3=A8s writes: [...] >> Could you use a vhash here instead of the hash table? > > Yes, that shouldn't be a problem. Could I ask why the request? I prefer functional style (except for build-side code), for clarity among other things. [...] >> I believe =E2=80=98upstream-packages=E2=80=99 (renamed to =E2=80=98depen= dent-packages=E2=80=99?) could >> be moved to (guix packages) and have a few tests as well. That=E2=80=99= d be >> great. >> >> WDYT? > > Because of the use of 'fold-packages' from (gnu packages), putting > dependent-packages into (guix packages) would cause a circular > dependency. Oh, right. > I think I'd also want to make the interface more general if it were to > go somewhere more widely available. OK. Ludo=E2=80=99.