unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add older ruby 1.8.7
@ 2014-10-25 22:58 Pjotr Prins
  2014-10-26  0:17 ` Mark H Weaver
  0 siblings, 1 reply; 9+ messages in thread
From: Pjotr Prins @ 2014-10-25 22:58 UTC (permalink / raw)
  To: David Thompson; +Cc: guix-devel

    * gnu/packages/ruby.scm: Added older Ruby 1.8.7
---
 gnu/packages/ruby.scm |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index ac751f5..0b10b87 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -89,6 +89,33 @@ a focus on simplicity and productivity.")
     (home-page "https://ruby-lang.org")
     (license license:ruby)))
 
+(define-public ruby-1.8
+  (package (inherit ruby)
+    (name "ruby")
+    (version "1.8.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "ftp://ftp.ruby-lang.org/pub/ruby/1.8/"
+                           name "-" version "-p374.tar.bz2"))
+     (sha256
+      (base32
+       "1qq7khilwkayrhwmzlxk83scrmiqfi7lgsn4c63znyvz2c1lgqxl"))))
+    (arguments
+     `(#:test-target "test"
+       #:parallel-tests? #f
+       #:phases
+        (alist-cons-before
+         'configure 'replace-bin-sh
+         (lambda _
+           (substitute* '("Makefile.in"
+                          "ext/pty/pty.c"
+                          "io.c"
+                          "lib/mkmf.rb"
+                          "process.c")
+             (("/bin/sh") (which "sh"))))
+         %standard-phases)))))
+
 (define-public ruby-i18n
   (package
     (name "ruby-i18n")
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-25 22:58 [PATCH] gnu: Add older ruby 1.8.7 Pjotr Prins
@ 2014-10-26  0:17 ` Mark H Weaver
  2014-10-26  2:09   ` Pjotr Prins
  0 siblings, 1 reply; 9+ messages in thread
From: Mark H Weaver @ 2014-10-26  0:17 UTC (permalink / raw)
  To: Pjotr Prins; +Cc: guix-devel

Pjotr Prins <pjotr.public12@thebird.nl> writes:

>     * gnu/packages/ruby.scm: Added older Ruby 1.8.7
> ---
>  gnu/packages/ruby.scm |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index ac751f5..0b10b87 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -89,6 +89,33 @@ a focus on simplicity and productivity.")
>      (home-page "https://ruby-lang.org")
>      (license license:ruby)))
>  
> +(define-public ruby-1.8
> +  (package (inherit ruby)
> +    (name "ruby")
> +    (version "1.8.7")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "ftp://ftp.ruby-lang.org/pub/ruby/1.8/"
> +                           name "-" version "-p374.tar.bz2"))

What's that "-p374" in the file name?  If it's a patch level, then I
think it should be part of the version string.

     Mark

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-26  0:17 ` Mark H Weaver
@ 2014-10-26  2:09   ` Pjotr Prins
  2014-10-26  4:34     ` Mark H Weaver
  0 siblings, 1 reply; 9+ messages in thread
From: Pjotr Prins @ 2014-10-26  2:09 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

Good point. How do we use patch levels anyway?

On Sat, Oct 25, 2014 at 08:17:58PM -0400, Mark H Weaver wrote:
> What's that "-p374" in the file name?  If it's a patch level, then I
> think it should be part of the version string.
> 
>      Mark
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-26  2:09   ` Pjotr Prins
@ 2014-10-26  4:34     ` Mark H Weaver
  2014-10-26  4:46       ` Pjotr Prins
  0 siblings, 1 reply; 9+ messages in thread
From: Mark H Weaver @ 2014-10-26  4:34 UTC (permalink / raw)
  To: Pjotr Prins; +Cc: guix-devel

Mark H Weaver wrote:
> What's that "-p374" in the file name?  If it's a patch level, then I
> think it should be part of the version string.

Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> Good point. How do we use patch levels anyway?

I'm sorry, I don't understand your question.  What does it mean to "use"
a patch level?

      Mark

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-26  4:34     ` Mark H Weaver
@ 2014-10-26  4:46       ` Pjotr Prins
  2014-10-26 14:00         ` Ludovic Courtès
  2014-10-26 18:47         ` Mark H Weaver
  0 siblings, 2 replies; 9+ messages in thread
From: Pjotr Prins @ 2014-10-26  4:46 UTC (permalink / raw)
  To: Mark H Weaver; +Cc: guix-devel

On Sun, Oct 26, 2014 at 12:34:49AM -0400, Mark H Weaver wrote:
> Mark H Weaver wrote:
> > What's that "-p374" in the file name?  If it's a patch level, then I
> > think it should be part of the version string.
> 
> Pjotr Prins <pjotr.public12@thebird.nl> wrote:
> > Good point. How do we use patch levels anyway?
> 
> I'm sorry, I don't understand your question.  What does it mean to "use"
> a patch level?

We have package-name and package-version. Why not package-patch-level?
I don't think it should be part of version.

Pj.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-26  4:46       ` Pjotr Prins
@ 2014-10-26 14:00         ` Ludovic Courtès
  2014-10-26 20:15           ` Pjotr Prins
  2014-10-26 18:47         ` Mark H Weaver
  1 sibling, 1 reply; 9+ messages in thread
From: Ludovic Courtès @ 2014-10-26 14:00 UTC (permalink / raw)
  To: Pjotr Prins; +Cc: guix-devel

Similar to what we do for Bash, the ‘version’ field should be
“1.8.7.374”, which would preserve ordering.

Ludo’.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-26  4:46       ` Pjotr Prins
  2014-10-26 14:00         ` Ludovic Courtès
@ 2014-10-26 18:47         ` Mark H Weaver
  1 sibling, 0 replies; 9+ messages in thread
From: Mark H Weaver @ 2014-10-26 18:47 UTC (permalink / raw)
  To: Pjotr Prins; +Cc: guix-devel

Pjotr Prins <pjotr.public12@thebird.nl> writes:
> We have package-name and package-version. Why not package-patch-level?
> I don't think it should be part of version.

I agree with Ludovic.  The patch-level is conceptually part of the
version.

We have a fair bit of program logic, APIs, and user interface elements
that assume that there's only one 'version' field.  All of those would
need to be changed to support an additional 'patch-level' field.  Doing
all of that work would require a compelling argument.  I don't see one.

      Mark

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-26 14:00         ` Ludovic Courtès
@ 2014-10-26 20:15           ` Pjotr Prins
  2014-10-26 21:04             ` Ludovic Courtès
  0 siblings, 1 reply; 9+ messages in thread
From: Pjotr Prins @ 2014-10-26 20:15 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

On Sun, Oct 26, 2014 at 03:00:48PM +0100, Ludovic Courtès wrote:
> Similar to what we do for Bash, the version field should be
> 1.8.7.374, which would preserve ordering.

The filename contains 1.8.7-p374. So, can I use that for the version?

Pj.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] gnu: Add older ruby 1.8.7
  2014-10-26 20:15           ` Pjotr Prins
@ 2014-10-26 21:04             ` Ludovic Courtès
  0 siblings, 0 replies; 9+ messages in thread
From: Ludovic Courtès @ 2014-10-26 21:04 UTC (permalink / raw)
  To: Pjotr Prins; +Cc: guix-devel

Pjotr Prins <pjotr.public12@thebird.nl> skribis:

> On Sun, Oct 26, 2014 at 03:00:48PM +0100, Ludovic Courtès wrote:
>> Similar to what we do for Bash, the version field should be
>> 1.8.7.374, which would preserve ordering.
>
> The filename contains 1.8.7-p374. So, can I use that for the version?

I have a preference for 1.8.7.374, but 1.8.7-p374 would work as well.

Ludo’.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-10-26 21:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-25 22:58 [PATCH] gnu: Add older ruby 1.8.7 Pjotr Prins
2014-10-26  0:17 ` Mark H Weaver
2014-10-26  2:09   ` Pjotr Prins
2014-10-26  4:34     ` Mark H Weaver
2014-10-26  4:46       ` Pjotr Prins
2014-10-26 14:00         ` Ludovic Courtès
2014-10-26 20:15           ` Pjotr Prins
2014-10-26 21:04             ` Ludovic Courtès
2014-10-26 18:47         ` Mark H Weaver

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).