From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add IcedTea 7. Date: Thu, 23 Apr 2015 22:37:11 +0200 Message-ID: <87y4libmyw.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlNs8-0001CI-9B for guix-devel@gnu.org; Thu, 23 Apr 2015 16:37:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlNs4-0008Mb-4A for guix-devel@gnu.org; Thu, 23 Apr 2015 16:37:20 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlNs4-0008MX-0h for guix-devel@gnu.org; Thu, 23 Apr 2015 16:37:16 -0400 In-Reply-To: (Ricardo Wurmus's message of "Tue, 21 Apr 2015 14:24:10 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: Guix-devel Ricardo Wurmus skribis: > IcedTea 7 is served! \o/ > The version numbers may be a little confusing. We are using the IcedTea > 2.5.5 framework and the OpenJDK 7 sources to build a "sanitised" version > of the OpenJDK 7. Since it's not exactly the OpenJDK that is built but > rather a cleaned up, liberated version, with IcedTea patches applied the > package name is "icedtea" rather than "openjdk". Sure. > The tests do not pass, unfortunately. There are *some* failures that > are seen in upstream builds, but our number of test failures is larger > than that. Some failures are probably related to the fact that I have > not added Xfvb to the native inputs for some tests; others are very > difficult for me to analyse and understand. Fair enough. > From 28581336e8bb9d0c77acdaf483addcbb242381d7 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Mon, 20 Apr 2015 12:55:20 +0200 > Subject: [PATCH 1/2] gnu: icedtea6: Split test fixing phases. > > * gnu/packages/java.scm (icedtea6)[arguments]: Split phase 'fix-tests into > three phases 'fix-test-framework, 'fix-hotspot-tests, and 'fix-jdk-test= s. OK! > From 2532230b43b4164fee363562534929e31f725428 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 24 Mar 2015 12:09:29 +0100 > Subject: [PATCH 2/2] gnu: Add icedtea7. > > * gnu/packages/java.scm (icedtea7): New variable. [...] > + #:locale "C" Could you add a comment explaining why? > + ,@(substitute-keyword-arguments `(#:modules ((guix build gnu-bu= ild-system) > + (guix build utils) > + (srfi srfi-1) > + (srfi srfi-26)) > + ,@(package-argument= s icedtea6)) The ,@ should be aligned with #:modules (unfortunately Emacs fails to do that by default.) > + ((#:phases phases) > + `(alist-replace This is typically a case where =E2=80=98modify-phases=E2=80=99 would be mor= e readable, if you feel like changing it. Otherwise OK. Thank you for the hard work! Ludo=E2=80=99.