From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/7] guix: git: Support shallow git clones if a tag is
	available
Date: Sun, 25 Oct 2015 22:30:55 +0100
Message-ID: <87y4eqk54g.fsf@gnu.org>
References: <1439893929.575691.5108@rusty> <876143o49y.fsf@gnu.org>
	<87twplin1u.fsf@dustycloud.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46704)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZqSsX-0004rC-Dt
	for guix-devel@gnu.org; Sun, 25 Oct 2015 17:31:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZqSsU-0001sH-3h
	for guix-devel@gnu.org; Sun, 25 Oct 2015 17:31:01 -0400
In-Reply-To: <87twplin1u.fsf@dustycloud.org> (Christopher Allan Webber's
	message of "Tue, 20 Oct 2015 10:20:09 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org

Christopher Allan Webber <cwebber@dustycloud.org> skribis:

> Ludovic Court=C3=A8s writes:
>
>> Andy Wingo <wingo@igalia.com> skribis:
>>
>>> * guix/build/git.scm (git-fetch): Instead of cloning the remote repo, u=
se the
>>>   lower-level "init" / "fetch" / "checkout" operations.  This lets us m=
ake a
>>>   shallow checkout if we are checking out a tag.
>>>
>>> * guix/git-download.scm (<git-reference>): Add tag field.
>>>   (git-fetch): Support git references with tags but no commits.
>>
>> This sounds like a nice improvement.  Please move the =E2=80=9CThis lets=
 us=E2=80=9D
>> sentence to a comment, and drop the newline between entries.
>
> This does look like a nice improvement!  It seems like it kind of got
> dropped on the floor.  Is there still interest?

Yes!  Would you like to look into it?  :-)

Ludo=E2=80=99.