From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] guix: git: Support shallow git clones if a tag is available
Date: Sun, 25 Oct 2015 22:30:55 +0100 [thread overview]
Message-ID: <87y4eqk54g.fsf@gnu.org> (raw)
In-Reply-To: <87twplin1u.fsf@dustycloud.org> (Christopher Allan Webber's message of "Tue, 20 Oct 2015 10:20:09 -0500")
Christopher Allan Webber <cwebber@dustycloud.org> skribis:
> Ludovic Courtès writes:
>
>> Andy Wingo <wingo@igalia.com> skribis:
>>
>>> * guix/build/git.scm (git-fetch): Instead of cloning the remote repo, use the
>>> lower-level "init" / "fetch" / "checkout" operations. This lets us make a
>>> shallow checkout if we are checking out a tag.
>>>
>>> * guix/git-download.scm (<git-reference>): Add tag field.
>>> (git-fetch): Support git references with tags but no commits.
>>
>> This sounds like a nice improvement. Please move the “This lets us”
>> sentence to a comment, and drop the newline between entries.
>
> This does look like a nice improvement! It seems like it kind of got
> dropped on the floor. Is there still interest?
Yes! Would you like to look into it? :-)
Ludo’.
next prev parent reply other threads:[~2015-10-25 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 8:03 [PATCH 1/7] guix: git: Support shallow git clones if a tag is available Andy Wingo
2015-08-25 14:02 ` Ludovic Courtès
2015-10-20 15:20 ` Christopher Allan Webber
2015-10-25 21:30 ` Ludovic Courtès [this message]
2015-10-26 7:46 ` Andy Wingo
2017-02-02 20:33 ` ng0
-- strict thread matches above, loose matches on Subject: below --
2015-08-18 8:03 Andy Wingo
2015-08-18 8:03 Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4eqk54g.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).