From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/2] gnu: Add Mlucas. Date: Thu, 05 Nov 2015 23:08:16 +0100 Message-ID: <87y4ec9k1b.fsf@gnu.org> References: <20151025141201.0f64fc35@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuShj-0005Te-1w for guix-devel@gnu.org; Thu, 05 Nov 2015 17:08:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuShf-0001xS-Pm for guix-devel@gnu.org; Thu, 05 Nov 2015 17:08:22 -0500 In-Reply-To: <20151025141201.0f64fc35@debian> (Alex Vong's message of "Sun, 25 Oct 2015 14:12:01 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Vong Cc: guix-devel@gnu.org Alex Vong skribis: > From 876bbbeafaa2dae8e584820645ca21efecf6ae7c Mon Sep 17 00:00:00 2001 > From: Alex Vong > Date: Sun, 25 Oct 2015 00:18:29 +0800 > Subject: [PATCH 2/2] gnu: Add Mlucas. > > * gnu/packages/mlucas.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Register it. I agree with Paul that maths.scm would be more appropriate. > +;;; the Free Software Foundation; either version 3 of the License, or > (at +;;; your option) any later version. The MUA is breaking lines. Could you try to disable it? > + (flag-list- > + (flag-list+ all-flag-list > + (flag-list > + #:CFLAGS '("-Ofast" > + "-pipe" > + "-flto" > + "-fno-aggressive-loop-optimizations") > + #:LDFLAGS '("-Wl,--as-needed"))) For now, could you just pass these as #:configure-flags? I think =E2=80=98-pipe=E2=80=99 can be omitted nowdays (and cpp is no longe= r a separate process.) I=E2=80=99m not sure if =E2=80=98-Ofast=E2=80=99 is OK: it might entail som= ething equivalent to =E2=80=98-mtune=3Dnative=E2=80=99, which is inappropriate if the software i= s to be distributed by Hydra. > + default-flag-list))) [...] > + (modify-phases %standard-phases > + (add-before 'configure > + 'bootstrap > + (lambda _ > + (zero? (system "./bootstrap"))))) Please use =E2=80=98system*=E2=80=99. Also indent as in the other files. > + #:configure-flags > + '("--disable-NORMAL-CFLAGS" > + "--disable-TRICKY-CFLAGS" Really? :-) > + ;; run-time dependencies > + (propagated-inputs `(("coreutils" ,coreutils) > + ("sed" ,sed))) Why is this needed? Could you put the justification in a comment? > + ;; build-time dependencies > + (native-inputs `(("autogen" ,autogen) > + ("autoconf" ,autoconf) > + ("automake" ,automake) > + ("perl" ,perl))) Does upstream provide a bootstrapped tarball, resulting from =E2=80=98make dist=E2=80=99? That would be best (no need to depend on Autoconf and Autom= ake.) > + (description "mlucas performs Lucas-Lehmer test =E2=80=9CMlucas=E2=80=9D maybe? > +on prime-exponent Mersenne numbers, > +that is, integers of the form 2 ^ p - 1, with prime exponent p. @math{2^p - 1} > +For more information on GIMPS, > +see for details. @uref{http://www.mersenne.org/prime.html} Could you send an updated patch? Thanks in advance, and sorry for the delay! Ludo=E2=80=99.