Re: [PATCH] gnu: Add inklingreader

[Roel Janssen <roel@gnu.org>]

[-- Attachment #1: 0001-gnu-Add-inklingreader-v2.patch --]
[-- Type: text/x-patch, Size: 3374 bytes --]

From 1cda4dd832a4c654cca7eff150217305ba60573e Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Tue, 10 Nov 2015 19:38:42 +0100
Subject: [PATCH] gnu: Add inklingreader.

* gnu/packages/inklingreader.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am                  |  1 +
 gnu/packages/inklingreader.scm | 59 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+)
 create mode 100644 gnu/packages/inklingreader.scm

diff --git a/gnu-system.am b/gnu-system.am
index f3ded69..f8b3d42 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -158,6 +158,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/image.scm			\
   gnu/packages/imagemagick.scm			\
   gnu/packages/indent.scm			\
+  gnu/packages/inklingreader.scm		\
   gnu/packages/inkscape.scm			\
   gnu/packages/irssi.scm			\
   gnu/packages/iso-codes.scm			\
diff --git a/gnu/packages/inklingreader.scm b/gnu/packages/inklingreader.scm
new file mode 100644
index 0000000..5c1d2f6
--- /dev/null
+++ b/gnu/packages/inklingreader.scm
@@ -0,0 +1,59 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Roel Janssen <roel@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages inklingreader)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages libusb)
+  #:use-module (gnu packages pkg-config))
+
+(define-public inklingreader
+  (package
+    (name "inklingreader")
+    (version "0.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-"
+                    version ".tar.gz"))
+              (sha256
+               (base32
+                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("glib" ,glib)
+       ("cairo" ,cairo)
+       ("librsvg" ,librsvg)
+       ("gtk+" ,gtk+)
+       ("libusb" ,libusb)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (home-page "https://www.gnu.org/software/inklingreader/")
+    (synopsis "Wacom Inkling sketch format conversion and manipulation.")
+    (description
+     "GNU InklingReader is a package to support the Wacom Inkling device,
+including data conversion to various free formats, basic editing features,
+and an Inkscape plugin.")
+    (license license:gpl3+)))
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 2199 bytes --]

Hi Mathieu,

Thanks for your reply.

Mathieu Lirzin writes:

>>From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Tue, 10 Nov 2015 15:01:33 +0100
>> Subject: [PATCH] gnu: Add inklingreader
>>
>> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
>> * gnu/packages/inklingreader.scm: The package description.
>
> Guix has somekind of "template" commit log when adding packages, you
> will find multiple examples with
>
>   git log --grep="(GNU_SYSTEM_MODULES): Add it"
>
> When applying it to your package you will obtain this.
>
> --8<---------------cut here---------------start------------->8---
> gnu: Add inklingreader.
>
> * gnu/packages/inklingreader.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
> --8<---------------cut here---------------end--------------->8---

Fixed.

>> ---
>>  gnu-system.am                  |  1 +
>>  gnu/packages/inklingreader.scm | 65 ++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 66 insertions(+)
>>  create mode 100644 gnu/packages/inklingreader.scm
> [...]
>> +++ b/gnu/packages/inklingreader.scm
>> @@ -0,0 +1,65 @@
>> [...]
>> +    (arguments `(#:configure-flags '("--enable-silent-rules")))
>
> this is automatically done, so this flag is not needed.

Fixed.

>> +    (inputs
>> +     `(("glib" ,glib)
>> +       ("cairo" ,cairo)
>> +       ("librsvg" ,librsvg)
>> +       ("gtk+" ,gtk+)
>> +       ("libusb" ,libusb)
>> +
>> +       ;; Needed to build the package.
>> +       ("texinfo" ,texinfo)))
>
> Actually the documentation is not built so I don't think this is needed.
> If you want to easily provide the documentation to Guix you will need to
> add the Automake variable "info_TEXINFOS" in you Makefile.am file in the
> next release, see:
>
>   https://www.gnu.org/software/automake/manual/automake.html#Texinfo

Fixed.

>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)))
>> +
>> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
>
> I think It would be better to provide
>
>   https://www.gnu.org/software/inklingreader/

Fixed.

> Can you send an updated patch?

I attached it.

Thanks for your time,
Roel Janssen