From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH] Add nautilus Date: Mon, 08 Feb 2016 13:46:29 +0800 Message-ID: <87y4avoitm.fsf@member.fsf.org> References: <81cb4d87f795011de938341a065bbccb@openmailbox.org> <874mdlz40p.fsf@member.fsf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSeew-0000QO-PU for guix-devel@gnu.org; Mon, 08 Feb 2016 00:46:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSeet-0001BE-Jx for guix-devel@gnu.org; Mon, 08 Feb 2016 00:46:50 -0500 Received: from smtp16.openmailbox.org ([62.4.1.50]:44517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSeet-0001B2-Dr for guix-devel@gnu.org; Mon, 08 Feb 2016 00:46:47 -0500 In-Reply-To: <874mdlz40p.fsf@member.fsf.org> (=?utf-8?B?IuWui+aWh+atpiIn?= =?utf-8?B?cw==?= message of "Sun, 07 Feb 2016 09:46:14 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: rennes@openmailbox.org Cc: guix-devel@gnu.org iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) writes: > rennes@openmailbox.org writes: > >> Hi, >> >> i attached patch for review. >> OK, I'm little hurry and pushed with following adjustments: - Move to gnome.scm. - Add comments. - Use glib-or-gtk-build-system. - Remove the '--disable-packagekit' flag, it only use dbus. - Move 'gtk+' to propagated-inputs. - Remove some unnecessarily inputs propagated by gnome-desktop. - Remove 'gvfs', I can't get it work now (eg: trash not working). I think it's like dconf which have a gio module using dbus to talk with a daemon, maybe the daemon should be propagated too. But since the gvfs package is big, I'll try split it latter. - Add copyright headers for us. Thanks for the patch!