unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] Add libotf.
@ 2016-02-19 10:04 Roel Janssen
  2016-02-19 10:29 ` 宋文武
  0 siblings, 1 reply; 4+ messages in thread
From: Roel Janssen @ 2016-02-19 10:04 UTC (permalink / raw)
  To: guix-devel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-libotf.patch --]
[-- Type: text/x-patch, Size: 1540 bytes --]

From 64cfdae64cfe9af4ff162935edd4e208a0f5afc1 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Fri, 19 Feb 2016 11:00:06 +0100
Subject: [PATCH] gnu: Add libotf.

* gnu/packages/fontutils.scm (libotf): New variable.
---
 gnu/packages/fontutils.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index 7b5b330..5cd7c56 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -259,6 +259,27 @@ resolution.")
     (license license:gpl2+)
     (home-page "http://potrace.sourceforge.net/")))
 
+(define-public libotf
+  (package
+    (name "libotf")
+    (version "0.9.13")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://download.savannah.gnu.org/releases/m17n/libotf-"
+                   version ".tar.gz"))
+              (sha256
+               (base32 "0239zvfan56w7vrppriwy77fzb10ag9llaz15nsraps2a2x6di3v"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("freetype" ,freetype)))
+    (home-page "http://www.nongnu.org/m17n/")
+    (synopsis "A Library for handling OpenType Font")
+    (description "The library can read Open Type Layout Tables from OTF file. 
+Currently these tables are supported; head, name, cmap, GDEF, GSUB, and GPOS.
+It can convert a Unicode character sequence to a glyph code sequence by using
+the above tables.")
+    (license license:lgpl2.0+)))
+
 (define-public libspiro
   (package
     (name "libspiro")
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 104 bytes --]

Dear list,

I'd like to add libotf, so here's a patch.  Feedback is
always welcome.

Kind regards,
Roel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add libotf.
  2016-02-19 10:04 [PATCH] Add libotf Roel Janssen
@ 2016-02-19 10:29 ` 宋文武
  2016-02-19 11:36   ` Roel Janssen
  0 siblings, 1 reply; 4+ messages in thread
From: 宋文武 @ 2016-02-19 10:29 UTC (permalink / raw)
  To: Roel Janssen; +Cc: guix-devel

Roel Janssen <roel@gnu.org> writes:

> From 64cfdae64cfe9af4ff162935edd4e208a0f5afc1 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Fri, 19 Feb 2016 11:00:06 +0100
> Subject: [PATCH] gnu: Add libotf.
>
> * gnu/packages/fontutils.scm (libotf): New variable.
> ---
>  gnu/packages/fontutils.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index 7b5b330..5cd7c56 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -259,6 +259,27 @@ resolution.")
>      (license license:gpl2+)
>      (home-page "http://potrace.sourceforge.net/")))
>  
> +(define-public libotf
> +  (package
> +    (name "libotf")
> +    (version "0.9.13")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://download.savannah.gnu.org/releases/m17n/libotf-"
this line is too long, shouldn’t more than 80 chars.
> +                   version ".tar.gz"))
> +              (sha256
> +               (base32 "0239zvfan56w7vrppriwy77fzb10ag9llaz15nsraps2a2x6di3v"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("freetype" ,freetype)))
No need to be ‘native-inputs’.  And does ‘freetype’ is in the ‘libotf.pc’
file?  If so, this should be in ‘propagate-inputs’.

<https://www.gnu.org/software/guix/manual/html_node/package-Reference.html>
for the details.

> +    (home-page "http://www.nongnu.org/m17n/")
> +    (synopsis "A Library for handling OpenType Font")
> +    (description "The library can read Open Type Layout Tables from OTF file. 
> +Currently these tables are supported; head, name, cmap, GDEF, GSUB, and GPOS.
> +It can convert a Unicode character sequence to a glyph code sequence by using
> +the above tables.")
The ‘synopsis’ shouldn’t start with “A” or “An”, expect for GNU
packages. And I think “This library” is better than “The library”
for ‘description’.
> +    (license license:lgpl2.0+)))
> +
>  (define-public libspiro
>    (package
>      (name "libspiro")

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add libotf.
  2016-02-19 10:29 ` 宋文武
@ 2016-02-19 11:36   ` Roel Janssen
  2016-02-20  0:43     ` 宋文武
  0 siblings, 1 reply; 4+ messages in thread
From: Roel Janssen @ 2016-02-19 11:36 UTC (permalink / raw)
  To: 宋文武; +Cc: guix-devel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-Add-libotf-v2.patch --]
[-- Type: text/x-patch, Size: 1570 bytes --]

From 96b52535da247b6c461612e3789cd22d8c6dd66a Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Fri, 19 Feb 2016 12:32:15 +0100
Subject: [PATCH] gnu: Add libotf.

* gnu/packages/fontutils.scm (libotf): New variable.
---
 gnu/packages/fontutils.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
index 7b5b330..cf46dbf 100644
--- a/gnu/packages/fontutils.scm
+++ b/gnu/packages/fontutils.scm
@@ -259,6 +259,28 @@ resolution.")
     (license license:gpl2+)
     (home-page "http://potrace.sourceforge.net/")))
 
+(define-public libotf
+  (package
+    (name "libotf")
+    (version "0.9.13")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://download.savannah.gnu.org/releases/m17n/libotf-"
+                    version ".tar.gz"))
+              (sha256
+               (base32 "0239zvfan56w7vrppriwy77fzb10ag9llaz15nsraps2a2x6di3v"))))
+    (build-system gnu-build-system)
+    (propagated-inputs
+     `(("freetype" ,freetype)))
+    (home-page "http://www.nongnu.org/m17n/")
+    (synopsis "Library for handling OpenType Font")
+    (description "This library can read Open Type Layout Tables from an OTF
+file.  Currently these tables are supported; head, name, cmap, GDEF, GSUB, and
+GPOS.  It can convert a Unicode character sequence to a glyph code sequence by
+using the above tables.")
+    (license license:lgpl2.0+)))
+
 (define-public libspiro
   (package
     (name "libspiro")
-- 
2.5.0


[-- Attachment #2: Type: text/plain, Size: 2373 bytes --]


Thank you for your quick reply.

宋文武 writes:

> Roel Janssen <roel@gnu.org> writes:
>
>> From 64cfdae64cfe9af4ff162935edd4e208a0f5afc1 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Fri, 19 Feb 2016 11:00:06 +0100
>> Subject: [PATCH] gnu: Add libotf.
>>
>> * gnu/packages/fontutils.scm (libotf): New variable.
>> ---
>>  gnu/packages/fontutils.scm | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
>> index 7b5b330..5cd7c56 100644
>> --- a/gnu/packages/fontutils.scm
>> +++ b/gnu/packages/fontutils.scm
>> @@ -259,6 +259,27 @@ resolution.")
>>      (license license:gpl2+)
>>      (home-page "http://potrace.sourceforge.net/")))
>>  
>> +(define-public libotf
>> +  (package
>> +    (name "libotf")
>> +    (version "0.9.13")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "http://download.savannah.gnu.org/releases/m17n/libotf-"
> this line is too long, shouldn’t more than 80 chars.
>> +                   version ".tar.gz"))
>> +              (sha256
>> +               (base32 "0239zvfan56w7vrppriwy77fzb10ag9llaz15nsraps2a2x6di3v"))))
>> +    (build-system gnu-build-system)
>> +    (native-inputs
>> +     `(("freetype" ,freetype)))
> No need to be ‘native-inputs’.  And does ‘freetype’ is in the ‘libotf.pc’
> file?  If so, this should be in ‘propagate-inputs’.
>
> <https://www.gnu.org/software/guix/manual/html_node/package-Reference.html>
> for the details.

Thanks for pointing this out.  I thought 'native-inputs' was for
dependencies at compile time..  I changed it to propagated-inputs.

>> +    (home-page "http://www.nongnu.org/m17n/")
>> +    (synopsis "A Library for handling OpenType Font")
>> +    (description "The library can read Open Type Layout Tables from OTF file. 
>> +Currently these tables are supported; head, name, cmap, GDEF, GSUB, and GPOS.
>> +It can convert a Unicode character sequence to a glyph code sequence by using
>> +the above tables.")
> The ‘synopsis’ shouldn’t start with “A” or “An”, expect for GNU
> packages. And I think “This library” is better than “The library”
> for ‘description’.

Fixed.

>> +    (license license:lgpl2.0+)))
>> +
>>  (define-public libspiro
>>    (package
>>      (name "libspiro")


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Add libotf.
  2016-02-19 11:36   ` Roel Janssen
@ 2016-02-20  0:43     ` 宋文武
  0 siblings, 0 replies; 4+ messages in thread
From: 宋文武 @ 2016-02-20  0:43 UTC (permalink / raw)
  To: Roel Janssen; +Cc: guix-devel

Pushed, thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-02-20  0:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 10:04 [PATCH] Add libotf Roel Janssen
2016-02-19 10:29 ` 宋文武
2016-02-19 11:36   ` Roel Janssen
2016-02-20  0:43     ` 宋文武

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).